mirrors
/
Defaults
mirror of https://github.com/sindresorhus/Defaults.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix infinite recursion when casting `AnySerializable` to wrong type (#147)

This commit is contained in:
Leo Mehlig 2023-09-03 08:37:52 +02:00 committed by GitHub
parent bd14dae265
commit 03d5386e58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/Defaults/Utilities.swift
View File

@ -194,7 +194,7 @@ extension Defaults.Serializable {
return anyObject return anyObject
} }
guard let nextType = T.Serializable.self as? any Defaults.Serializable.Type else { guard let nextType = T.Serializable.self as? any Defaults.Serializable.Type, nextType != T.self else {
// This is a special case for the types which do not conform to `Defaults.Serializable` (for example, `Any`). // This is a special case for the types which do not conform to `Defaults.Serializable` (for example, `Any`).
return T.bridge.deserialize(anyObject as? T.Serializable) as? T return T.bridge.deserialize(anyObject as? T.Serializable) as? T
} }

6
Tests/DefaultsTests/DefaultsAnySeriliazableTests.swift
View File

@ -466,4 +466,10 @@ final class DefaultsAnySerializableTests: XCTestCase {
waitForExpectations(timeout: 10) waitForExpectations(timeout: 10)
} }
func testWrongCast() {
let value = Defaults.AnySerializable(false)
XCTAssertEqual(value.get(Bool.self), false)
XCTAssertNil(value.get(String.self))
}
} }