From 712e12e23a8184d17b313cac27e1bef9a5784fc7 Mon Sep 17 00:00:00 2001 From: DreamPiggy Date: Tue, 2 Jul 2019 18:15:00 +0800 Subject: [PATCH] Follow App Store submit rule, upgrade the min Xcode version to Xcode 10.0 --- .github/ISSUE_TEMPLATE.md | 2 +- README.md | 2 +- SDWebImage/SDWebImageIndicator.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 3a2d6500..c39c7827 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -12,7 +12,7 @@ Platform Version | e.g. 12.0 / 10.14.0 / 12.0 / 5.0 SDWebImage Version | e.g. 5.0.0 / 4.4.0 Integration Method | e.g. carthage / cocoapods / manually - Xcode Version | e.g. Xcode 10 / Xcode 9 + Xcode Version | e.g. Xcode 11 / Xcode 10 Repro rate | e.g. all the time (100%) / sometimes x% / only once Repro with our demo prj | e.g. does it happen with our demo project? Demo project link | e.g. link to a demo project that highlights the issue diff --git a/README.md b/README.md index 5270e70c..575abbec 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ You can use those directly, or create similar components of your own. - tvOS 9.0 or later - watchOS 2.0 or later - macOS 10.10 or later -- Xcode 9.0 or later +- Xcode 10.0 or later #### Backwards compatibility diff --git a/SDWebImage/SDWebImageIndicator.m b/SDWebImage/SDWebImageIndicator.m index 458c38a5..e89d7260 100644 --- a/SDWebImage/SDWebImageIndicator.m +++ b/SDWebImage/SDWebImageIndicator.m @@ -18,7 +18,7 @@ #if __IPHONE_13_0 || __TVOS_13_0 || __MAC_10_15 // Xcode 11 #else -// Supports Xcode 9 && 10 users, for those users, define these enum +// Supports Xcode 10 users, for those users, define these enum static NSInteger UIActivityIndicatorViewStyleMedium = 100; static NSInteger UIActivityIndicatorViewStyleLarge = 101; #endif