From de149aedaa8915463900f427e0c9fc9a12e2ca26 Mon Sep 17 00:00:00 2001 From: Bogdan Poplauschi Date: Tue, 7 Jun 2016 11:56:31 +0300 Subject: [PATCH 1/3] Reverted all the changes for "Removed the URL query params from the filename (key)" fb0cdb6d 1bf62d4 #1584 - fixes #1433 #1553 #1583 #1585 This is a deal breaker for people. The solution for those issues (i.e. very long urls) is to set the SDWebImageManager cacheKeyFilter block and do their own calculations there. --- CHANGELOG.md | 2 +- SDWebImage/SDWebImageManager.m | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adefeb16..bb2bd43f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ #### Fixes: -- Removed the URL query params from the filename (key) fb0cdb6d 1bf62d4 #1584 - fixes #1433 #1533 #1583 #1585 +- Removed the URL query params from the filename (key) fb0cdb6d 1bf62d4 #1584 - fixes #1433 #1553 #1583 #1585 - Fixed the WebP build with the official 1.0.0 CocoaPods release f1a471e - fixes #1444 - Updated doc: `removeImageForKey:` not synchronous e6e5c51 - fixes #1379 #1415 diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m index cdfa1fc9..d331a4a5 100644 --- a/SDWebImage/SDWebImageManager.m +++ b/SDWebImage/SDWebImageManager.m @@ -61,13 +61,7 @@ if (self.cacheKeyFilter) { return self.cacheKeyFilter(url); } else { - if (NSClassFromString(@"NSURLComponents") && [NSURLComponents instancesRespondToSelector:@selector(string)]) { - NSURLComponents *urlComponents = [[NSURLComponents alloc] initWithURL:url resolvingAgainstBaseURL:NO]; - urlComponents.query = nil; // Strip out query parameters. - return [urlComponents.URL absoluteString]; - } else { - return [url absoluteString]; - } + return [url absoluteString]; } } From 67329ac512c10ea5d137e48d6a5522b578325350 Mon Sep 17 00:00:00 2001 From: Bogdan Poplauschi Date: Tue, 7 Jun 2016 11:57:03 +0300 Subject: [PATCH 2/3] Bumped the version --- SDWebImage.podspec | 2 +- WebImage/Info.plist | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SDWebImage.podspec b/SDWebImage.podspec index 086f620b..73facd4b 100644 --- a/SDWebImage.podspec +++ b/SDWebImage.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'SDWebImage' - s.version = '3.8.0' + s.version = '3.8.1' s.ios.deployment_target = '7.0' s.tvos.deployment_target = '9.0' s.license = 'MIT' diff --git a/WebImage/Info.plist b/WebImage/Info.plist index ddbaa33b..9467a966 100644 --- a/WebImage/Info.plist +++ b/WebImage/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 3.8.0 + 3.8.1 CFBundleSignature ???? CFBundleVersion From c012fc9bb2e5b1775a8a4a847938352187496a05 Mon Sep 17 00:00:00 2001 From: Bogdan Poplauschi Date: Tue, 7 Jun 2016 12:00:00 +0300 Subject: [PATCH 3/3] Updated the changelog --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb2bd43f..8ada48e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## [3.8.1 Patch release for 3.8.0 on Jun 7th, 2016](https://github.com/rs/SDWebImage/releases/tag/3.8.1) + +#### Fixes: + +- SDWebImage 3.8.0 get wrong image #1589 - the issue was caused by the changes in 3.8.0 (Removed the URL query params from the filename (key) fb0cdb6d 1bf62d4 #1584 - fixes #1433 #1553 #1583 #1585) - Reverted. +- Note: The solution for those issues (i.e. #1433 #1553) is to set the `SDWebImageManager` `cacheKeyFilter` block and do their own calculations there. + ## [3.8.0 Minor release - Replaces NSURLConnection (deprecated) with NSURLSession - on Jun 6th, 2016](https://github.com/rs/SDWebImage/releases/tag/3.8.0) #### Infrastructure: