mirrors
/
SDWebImage
mirror of https://github.com/SDWebImage/SDWebImage.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2825 from dreampiggy/fix_sdanimatedimageview_dealloc_on_global_queue 

Fix the case when SDAnimatedImageView dealloc on the fetch queue, will cause it trigger the UIKit/AppKit method on non-main queue and captured by UI Main Thread Checker
This commit is contained in:
Kinarobin 2019-09-04 11:55:13 +08:00 committed by DreamPiggy
parent ea76da958f
commit c9ea3f12bf
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
SDWebImage/Core/SDAnimatedImageView.m
View File

@ -665,7 +665,12 @@ static NSUInteger SDDeviceFreeMemory() {
if (!fetchFrame && !bufferFull && self.fetchQueue.operationCount == 0) {
// Prefetch next frame in background queue
UIImage<SDAnimatedImage> *animatedImage = self.animatedImage;
@weakify(self);
NSOperation *operation = [NSBlockOperation blockOperationWithBlock:^{
@strongify(self);
if (!self) {
return;
}
UIImage *frame = [animatedImage animatedImageFrameAtIndex:fetchFrameIndex];
BOOL isAnimating = NO;
@ -679,6 +684,10 @@ static NSUInteger SDDeviceFreeMemory() {
self.frameBuffer[@(fetchFrameIndex)] = frame;
SD_UNLOCK(self.lock);
}
// Ensure when self dealloc, it dealloced on the main queue (UIKit/AppKit rule)
dispatch_async(dispatch_get_main_queue(), ^{
[self class];
});
}];
[self.fetchQueue addOperation:operation];
}