Merge pull request #2381 from zhongwuzw/fix-download-token-crash

Fix crash when assign request property of SDWebImageDownloadToken
This commit is contained in:
DreamPiggy 2018-07-09 22:44:12 +08:00 committed by GitHub
commit d7e5d6df49
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -109,12 +109,12 @@ typedef SDImageLoaderCompletedBlock SDWebImageDownloaderCompletedBlock;
/** /**
The download's request. The download's request.
*/ */
@property (nonatomic, copy, nullable, readonly) NSURLRequest *request; @property (nonatomic, strong, nullable, readonly) NSURLRequest *request;
/** /**
The download's response. The download's response.
*/ */
@property (nonatomic, copy, nullable, readonly) NSURLResponse *response; @property (nonatomic, strong, nullable, readonly) NSURLResponse *response;
@end @end

View File

@ -19,8 +19,8 @@ static void * SDWebImageDownloaderContext = &SDWebImageDownloaderContext;
@interface SDWebImageDownloadToken () @interface SDWebImageDownloadToken ()
@property (nonatomic, strong, nullable, readwrite) NSURL *url; @property (nonatomic, strong, nullable, readwrite) NSURL *url;
@property (nonatomic, copy, nullable, readwrite) NSURLRequest *request; @property (nonatomic, strong, nullable, readwrite) NSURLRequest *request;
@property (nonatomic, copy, nullable, readwrite) NSURLResponse *response; @property (nonatomic, strong, nullable, readwrite) NSURLResponse *response;
@property (nonatomic, strong, nullable, readwrite) id downloadOperationCancelToken; @property (nonatomic, strong, nullable, readwrite) id downloadOperationCancelToken;
@property (nonatomic, weak, nullable) NSOperation<SDWebImageDownloaderOperation> *downloadOperation; @property (nonatomic, weak, nullable) NSOperation<SDWebImageDownloaderOperation> *downloadOperation;
@property (nonatomic, weak, nullable) SDWebImageDownloader *downloader; @property (nonatomic, weak, nullable) SDWebImageDownloader *downloader;