mirrors
/
SDWebImage
mirror of https://github.com/SDWebImage/SDWebImage.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix SDWebImageCombinedOperation was leak. 

When the task is executed in a concurrent queue, when the user scrolls up and down in the List, the function call "sd_setImageWithURL:placeholderImage:options:progress:completed:" will be triggered to "SDWebImageCombinedOperation cancel",
         and the real task will be Cancel was called, which caused the task to be executed in multi-threaded execution until the "operation.isCancelled" in "SDImageCache queryDiskCacheForKey:done:" was returned.

         Through the principle of opening and closing, when we add, we guarantee that there must be a place to be removed.

         Since the block supports the ability of external coverage, the approach here is the same as
         operation.cancelBlock = ^{
                          [subOperation cancel];

         This code does not conflict

         There is a bug that SDWebImageCombinedOperation is not released.
This commit is contained in:
snow.wu 2021-08-20 19:43:04 +08:00
parent 2eca5c7f04
commit e7210f104d
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
SDWebImage/SDWebImageManager.m
View File

@ -148,6 +148,30 @@
@synchronized (self.runningOperations) {
[self.runningOperations addObject:operation];
/*
Fix: Memory bug
When the task is executed in a concurrent queue, when the user scrolls up and down in the List, the function call "sd_setImageWithURL:placeholderImage:options:progress:completed:" will be triggered to "SDWebImageCombinedOperation cancel",
and the real task will be Cancel was called, which caused the task to be executed in multi-threaded execution until the "operation.isCancelled" in "SDImageCache queryDiskCacheForKey:done:" was returned.
Through the principle of opening and closing, when we add, we guarantee that there must be a place to be removed.
Since the block supports the ability of external coverage, the approach here is the same as
operation.cancelBlock = ^{
[subOperation cancel];
This code does not conflict
There is a bug that SDWebImageCombinedOperation is not released.
*/
__weak __typeof(self) weakSelf = self;
operation.cancelBlock = ^{
__strong __typeof(weakSelf) strongSelf = weakSelf;
__strong __typeof(weakOperation) strongOperation = weakOperation;
if (strongOperation) {
[strongSelf.runningOperations removeObject:strongOperation];
}
};
}
NSString *key = [self cacheKeyForURL:url];