From f6771d8fcdc4ef160b124845caae0b53923fbf79 Mon Sep 17 00:00:00 2001 From: DreamPiggy Date: Wed, 17 Jul 2024 15:34:59 +0800 Subject: [PATCH] Try to re-enable the HEIC encoding test and visionOS xctest --- .github/workflows/CI.yml | 10 +++++----- Tests/Tests/SDImageCoderTests.m | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 920c95f0..e248c955 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -103,7 +103,7 @@ jobs: strategy: fail-fast: false matrix: - platform: [iOS, macOS, tvOS] + platform: [iOS, macOS, tvOS, visionOS] include: - platform: iOS destination: platform=iOS Simulator,name=iPhone 15 Pro @@ -117,10 +117,10 @@ jobs: destination: platform=tvOS Simulator,name=Apple TV 4K (3rd generation) scheme: TV flag: tvos - # - platform: visionOS - # destination: platform=visionOS Simulator,name=Apple Vision Pro - # scheme: Vision - # flag: visionos + - platform: visionOS + destination: platform=visionOS Simulator,name=Apple Vision Pro + scheme: Vision + flag: visionos steps: - name: Checkout uses: actions/checkout@v3 diff --git a/Tests/Tests/SDImageCoderTests.m b/Tests/Tests/SDImageCoderTests.m index 1cc0e778..9729e978 100644 --- a/Tests/Tests/SDImageCoderTests.m +++ b/Tests/Tests/SDImageCoderTests.m @@ -206,7 +206,7 @@ - (void)test13ThatHEICWorks { if (@available(iOS 11, tvOS 11, macOS 10.13, *)) { NSURL *heicURL = [[NSBundle bundleForClass:[self class]] URLForResource:@"TestImage" withExtension:@"heic"]; - BOOL supportsEncoding = !SDTestCase.isCI; // GitHub Action Mac env currently does not support HEIC encoding + BOOL supportsEncoding = YES; // GitHub Action Mac env supported from 20240707.1 [self verifyCoder:[SDImageIOCoder sharedCoder] withLocalImageURL:heicURL supportsEncoding:supportsEncoding @@ -237,7 +237,7 @@ - (void)test16ThatHEICAnimatedWorks { if (@available(iOS 13, tvOS 13, macOS 10.15, *)) { NSURL *heicURL = [[NSBundle bundleForClass:[self class]] URLForResource:@"TestImageAnimated" withExtension:@"heic"]; - BOOL supportsEncoding = !SDTestCase.isCI; // GitHub Action Mac env currently does not support HEIC encoding + BOOL supportsEncoding = YES; // GitHub Action Mac env supported from 20240707.1 BOOL isAnimatedImage = YES; [self verifyCoder:[SDImageHEICCoder sharedCoder] withLocalImageURL:heicURL @@ -297,7 +297,7 @@ } - (void)test21ThatEmbedThumbnailHEICWorks { - BOOL supportsEncoding = !SDTestCase.isCI; // GitHub Action Mac env currently does not support HEIC encoding + BOOL supportsEncoding = YES; // GitHub Action Mac env supported from 20240707.1 if (!supportsEncoding) { return; }