Commit Graph

3629 Commits

Author SHA1 Message Date
Cédric Luthi 0b5291517f Fix completionBlock setter semantics
Using `SDDispatchQueueSetterSementics`, which might be `assign` for a block is a terrible idea.
2013-04-17 16:31:04 +03:00
Randall Li 9f4e6915c7 Added auto release pool to keep memory foot print down when retrieving image from disk in queryDiskCacheForKey 2013-04-05 08:57:11 +02:00
Olivier Poitrey 7d6e17c43c Merge pull request #355 from u16suzu/fix_double_import
Remove double import for SDWebImageDecoder.h
2013-03-29 05:48:29 -07:00
u16suzu 7d12c3e9fc Remove double import for SDWebImageDecoder.h 2013-03-29 05:17:43 -07:00
Jon Parise 32f011185a Support a maximum disk cache size in -cleanDisk.
Previously, -cleanDisk would only remove cache files that were older
than the configured expiration date.  This allowed the disk cache to
grow significantly if a large number of resources were cached over a
short period of time.

This change adds a second (optional) size-based cleaning pass that
removes files from the disk cache until its overall size falls below
half of the configured maximum size.  Older files are deleted first.

The size-based pass is disabled by default (maxCacheSize == 0).
2013-03-27 19:06:22 -07:00
Olivier Poitrey 1655803bc7 Merge pull request #352 from jparise/getSize-return-type
-getSize now returns an `unsigned long long`.
2013-03-27 15:53:23 -07:00
Jon Parise 1e37b716c7 -getSize now returns an `unsigned long long`.
This type now matches the type and width of the value returned by the
`fileSize` accessor of the `NSDictionary (NSFileAttributes)` category
(which is what is used when accumulating the total cache size).
2013-03-27 14:55:30 -07:00
Olivier Poitrey eda987815b Merge pull request #351 from Vyazovoy/master
New name for SDWebImageDownloaderQueueMode type, typo fixing, strong cycle fixing.
2013-03-27 10:04:09 -07:00
Andrew Vyazovoy c3968b30ce Merge branch 'develop'
* develop:
  Potential strong cycle fixed.
  SDWebImageDownloaderQueueMode type renamed. Fixed typo. Added description for renamed type. Type renamed because "queue" notion is a FIFO only, but LIFO is a stack, and if we give the type a neutral name, we can avoid logical inconsistencies.
  Fixed typo.
2013-03-27 23:45:47 +07:00
Andrew Vyazovoy c77652755a Potential strong cycle fixed. 2013-03-27 23:44:47 +07:00
Andrew Vyazovoy ee9af6406c SDWebImageDownloaderQueueMode type renamed. Fixed typo. Added description for renamed type. Type renamed because "queue" notion is a FIFO only, but LIFO is a stack, and if we give the type a neutral name, we can avoid logical inconsistencies. 2013-03-27 23:43:42 +07:00
Andrew Vyazovoy 6284e4070d Fixed typo. 2013-03-27 22:33:20 +07:00
Olivier Poitrey c50be70558 Inline the SDScaledImageForPath function so it doesn't polute the stack traces 2013-03-25 15:02:28 +01:00
Olivier Poitrey 4c51485e22 Merge pull request #344 from Kapin/master
Fixing comments to better reflect how methods work and some typo fixes
2013-03-22 12:34:24 -07:00
Joshua Kalpin 7779896163 Updating comments to be more accurate and fix typos 2013-03-22 15:10:00 -04:00
odanu 474b0d9496 Added SDWebImageCompact.m to Compile sources of the SDWebImage+MKAnnotation target 2013-03-20 03:44:18 -07:00
Olivier Poitrey f04b4a0731 Fix OS_OBJECT_USE_OBJC handling (fix #329) 2013-03-13 14:43:34 +01:00
Olivier Poitrey f747804843 Add some words about SDWebImageRefreshCached in README 2013-03-13 00:11:17 +01:00
Olivier Poitrey b1f1c08be6 Bump version 3.2 2013-03-12 23:40:18 +01:00
Olivier Poitrey fb28dfeb75 Merge pull request #327 from bm-i/patch-1
Fix SDWebImageManager transformDownloadedImage
2013-03-12 15:38:20 -07:00
bm-i 55096d8b91 Fix SDWebImageManager transformDownloadedImage
storing data of transformed image instead of downloaded one
(passing nil to storeImage will generate data)
2013-03-12 23:32:35 +01:00
Olivier Poitrey 8cfd26f78b Disable duplicate disk cache prevention with SDWebImageRefreshCached to handle 302 caching correctly
See https://github.com/rs/SDWebImage/pull/326#issuecomment-14791505 for more info
2013-03-12 19:26:53 +01:00
Olivier Poitrey 9a29af466b Fix typo 2013-03-12 19:15:25 +01:00
Olivier Poitrey eed78e37e8 Ensure image isn't decoded twice if not necessary when SDWebImageRefreshCached flag is used #326 2013-03-12 16:35:35 +01:00
Olivier Poitrey a3e3c61d46 Prevent double disk caching when `SDWebImageRefreshCached` option is used #326 2013-03-12 14:55:29 +01:00
Olivier Poitrey 9b574e58bf Force progressive download off when force refresh is on #326 2013-03-12 14:55:05 +01:00
Olivier Poitrey f097ef7558 Fix NSURLResponse not cached when `SDWebImageDownloaderEnableNSURLCache` is passed #326 2013-03-12 14:31:48 +01:00
Olivier Poitrey 5cd7c0db46 Fix condition logic issue in #326 2013-03-12 14:31:24 +01:00
Steven Chan bbad1bcfcc New option SDWebImageRefreshCached
Even if the image is cached, fetch the URL again anyway. When set,
NSURLCache is enabled in the downloader via the new option
SDWebImageDownloaderEnableNSURLCache.

NSURLCache will handle the protocol caching while SDWebImage remains
useful for offline images.

This option helps deal with images changing behind the same request URL,
e.g. Facebook graph api profile pics where the request URL
https://graph.facebook.com/[userid]/picture returns a redirect to the
actual profile image.

If a cached image exists, the completion block is called once with the
cached image and again with the final image.
2013-03-12 01:08:57 +08:00
Olivier Poitrey 95337c47e9 Merge pull request #311 from sebreh/master
Detect cancelled parent operation in download operation callback
2013-02-26 06:02:41 -08:00
Sebastian Rehnby d57b92cd0e Detect parent operation cancellation in download operation completion block 2013-02-26 12:08:55 +01:00
Olivier Poitrey 05dd3f4815 Merge pull request #307 from nebillo/master
Optimizing enumeration of files while cleaning the disk cache
2013-02-20 17:26:00 -08:00
Nebil Kriedi fbf14d2e16 Prefetching file properties in the disk cleaning enumerator 2013-02-21 01:07:44 +00:00
Olivier Poitrey ae57215c29 Merge pull request #302 from n-miyo/fix_cache_policy
Wrong cache policy value.
2013-02-19 17:04:12 -08:00
MIYOKAWA, Nobuyoshi 15c5785320 correct cachePolicy constants.
NSMutableURLRequest accepts NSURLRequestCachePolicy as cachePolicy,
not NSURLCacheStoragePolicy.
2013-02-19 13:10:31 +09:00
Olivier Poitrey f024890ba7 Add (kinda) LIFO queue mode support for image downloading (fix #294) 2013-02-17 03:02:04 +01:00
Olivier Poitrey 350c0bea9a Add completion block support to `SDWebImagePrefetcher` (fix #127) 2013-02-17 02:43:46 +01:00
Olivier Poitrey ebd63a88c1 Add `SDWebImageManager` delegate allowing fine control of manager's cache-in
- `imageManager:shouldDownloadImageForURL:` let delegate to conditionaly block cache-in (fix #134)
- `imageManager:transformDownloadedImage:` let delegate to transform the image prior to cache-in (fix #63, fix #284)
2013-02-17 00:55:27 +01:00
Olivier Poitrey 6f198abd1b Add ability to set custom downloader HTTP headers (fix #171) 2013-02-16 23:33:41 +01:00
Olivier Poitrey 5f535602f1 Merge pull request #299 from Reflejo/master
Fix "Alpha on JPEG with no alpha" when decoding
2013-02-16 10:41:14 -08:00
Olivier Poitrey b27d5719c2 Synchronize access to SDWebImageManager's mutable structures (fix #301) 2013-02-16 17:49:27 +01:00
Martin Conte Mac Donell de19c24241 [BUG] Fix invalid alpha on JPEG files 2013-02-13 21:55:26 -03:00
Olivier Poitrey a8a398386b Merge pull request #297 from inamiy/disk-cache
Add synchronous disk-cache loading method.
2013-02-13 07:21:31 -08:00
Yasuhiro Inami 17cc72d5ab Add synchronous disk-cache loading method. 2013-02-13 19:07:56 +09:00
Olivier Poitrey de485a8618 Fix downloader queue using assign instead of strong under iOS 6 2013-02-12 01:17:55 +01:00
Olivier Poitrey 63178bde3c Revert "Fixed CGBitmapContextCreate warnings for invalid alpha properties"
This reverts commit 12196f4de6.
It adds alpha on JPEG with no alpha.
2013-02-07 18:15:16 +01:00
Olivier Poitrey 87568ce141 Merge pull request #287 from NachoSoto/disk-cache
Check SDWebImageCacheMemoryOnly for disk caching
2013-01-29 15:02:01 -08:00
NachoSoto 42c7455776 Check SDWebImageCacheMemoryOnly for disk caching 2013-01-29 20:10:09 +00:00
Olivier Poitrey e7c02bb910 Migrate the no longer github supported download page to a wiki page 2013-01-21 09:36:08 +01:00
Olivier Poitrey 3016754250 Share framework target 2013-01-21 09:27:53 +01:00