Commit Graph

3592 Commits

Author SHA1 Message Date
andybee f87c057cb8 Made fix ARC-safe 2012-04-04 22:15:06 +02:00
andybee ba818f0d65 Attempting to fix rs/SDWebImage#84 by passing success/failure blocks in user info dictionary. This avoids holding success and failure block in manager object which is used as a singleton by the UIImageView and UIButton additions classes, thus repeatedly calling the same block multiple times when making multiple requests. 2012-04-04 21:19:57 +02:00
Olivier Poitrey e63e925821 Merge pull request #91 from andybee/master
@2x retina support is broken when images pass through UIImage (ForceDecode) addition
2012-04-04 05:36:25 -07:00
andybee 0cd7f6953b Allowed original image scale to be preserved. 2012-04-04 13:34:55 +02:00
Olivier Poitrey 61df06926a Fix placeholder not passed to the designated follow up method (fix #87) 2012-03-29 11:27:14 +02:00
Olivier Poitrey 2283e2e458 Merge pull request #86 from tvon/patch-1
SDWebImageDownloader adds excessive observers when SDNetworkActivityIndicator is used
2012-03-28 13:34:27 -07:00
Tom von Schwerdtner 6ca759f182 Two observers get added every time downloaderWithURL is called, which is unnecessary and seems to result in an imbalance in SDNetworkActivityIndicator between startActivity and stopActivity calls (which leads to the indicator not showing when it should during any initial app activity).
This fix is possibly not ideal, but it does the trick.
2012-03-28 16:27:31 -03:00
Olivier Poitrey dfa03af19f Fix a mem leak in SDWebImageDownloader (fix #83) 2012-03-22 11:40:05 +01:00
Olivier Poitrey a8d5b3ec72 Fix a bug in SDImageCache making first request to disk cache to always return nil (fix #81) 2012-03-22 10:37:23 +01:00
Olivier Poitrey 14b79734d2 Add some common problem tips 2012-03-22 10:33:07 +01:00
Olivier Poitrey 24f0842ea0 Treat image URL with response status code >= 400 as errors (fix #79) 2012-03-19 19:13:18 +01:00
Olivier Poitrey 1cf1703ec1 Add MKAnnotationView+WebCache category (fix #78) 2012-03-14 22:05:03 +01:00
Olivier Poitrey 580a90d6a0 Better ARC support 2012-03-12 11:46:16 +01:00
Olivier Poitrey ab97899a23 Add macro for ARC conditional call to [super dealloc] 2012-03-11 16:59:37 +01:00
Olivier Poitrey dcc6673bf1 Fix an EXC_BAD_ACCESS introduced by aa6956e9fc (fix #77) 2012-03-11 16:49:33 +01:00
Olivier Poitrey 6781045698 Add some backward compatible block support (fix #64) 2012-03-10 20:15:06 +01:00
Olivier Poitrey 30b9534294 Add some callback methods to SDWebImageManager protocol with requested URL appended (fix #67) 2012-03-10 18:22:07 +01:00
Olivier Poitrey 3074f55de2 Fix a conditing preventing from disk caching when data is not provided (fix #69) 2012-03-10 17:53:24 +01:00
Olivier Poitrey 8357f64a68 Add ARC info in README 2012-03-10 17:40:02 +01:00
Olivier Poitrey c327ee3737 Remove conditional activation of the new decoder optimization (now it's always activated) 2012-03-10 17:34:34 +01:00
Olivier Poitrey 40bcaa1181 Make SDWebImage ARC friendly by detecting if project is using ARC or not and do the right thing with retain and release 2012-03-10 17:32:24 +01:00
Olivier Poitrey aa6956e9fc Refactor 2x scale support 2012-03-10 16:30:43 +01:00
Sebastian Vieira c972489931 absoluteString for iOS 3 2012-03-10 16:30:43 +01:00
Sebastian Vieira 3ef0f609fd checking if uiimage supports the scale parameter for retina display phones (only supported form ios 4 onwards) 2012-03-10 16:30:43 +01:00
Sebastian Vieira baea8eed4a Adding the ability to render retina display images based on the file to which the url is pointing at 2012-03-10 16:30:43 +01:00
Olivier Poitrey 6660c51d36 Merge pull request #65 from ecentinela/master
Added a method to see the cache size
2012-03-10 06:01:48 -08:00
Olivier Poitrey 05725b4ab5 Merge pull request #70 from besi/patch-1
Fixed typos
2012-02-22 08:03:04 -08:00
Beat Besmer 03142f607c Fixed typos 2012-02-22 16:37:23 +01:00
Javier Martinez Fernandez e5cd63617f Added a method to see cache size. 2012-02-07 11:43:29 +01:00
Olivier Poitrey b207dcc6a8 Setup xcode project to allow import in a project as a static library 2012-01-28 00:05:40 +01:00
Adam Ernst 8318b295bf Introduce a cacheURLs array to prevent race conditions related to checking the on-disk image cache. (Fix #47)
If a cache check is initiated, then canceled with cancelForDelegate: before a new cache check
is started with a different URL but the same delegate, the ongoing disk cache check would still
message the delegate despite being canceled by cancelForDelegate:. This is because it only
checked to see if the delegate was in the cacheDelegates array; it had been removed by
cancelForDelegate:, but added back by the new unrelated cache check. cacheURLs keeps track
of which specific URLs are actually requested by the delegate. If the URL from a completed
disk cache check does not match the delegate in cacheDelegates, the delegate is not messaged
(since we know that request was canceled).
2011-12-05 15:56:32 +01:00
Olivier Poitrey 86b60e9c98 Add Xcode project 2011-12-05 02:50:29 +01:00
Fernando Saragoca 0dfb649faf Documented categories (appledoc) 2011-11-23 00:33:57 +01:00
Olivier Poitrey b3d7a5c450 Merge pull request #39 from 433/version_check_fix
update version check to make #if work for iOS >= 4
2011-10-25 04:00:34 -07:00
Ilya Samartsev 6cda5dcf4d update version check to make #if work for iOS >= 4 2011-10-25 11:02:50 +04:00
Olivier Poitrey 17450bdf1f Merge pull request #37 from neogithub/patch-1
Update README.md
2011-10-20 11:15:07 -07:00
neogithub 0b9b945a37 Update README.md 2011-10-20 10:03:19 -03:00
Olivier Poitrey 23ae1cb00c Add SDWebImagePrefetcher, an utility class to preventively warm-up SDWebImage cache (fix #32)
Contributed by https://github.com/mystcolor
2011-10-04 16:07:36 +02:00
Olivier Poitrey 9e2d414c28 Fix wrong options values 2011-10-04 16:05:32 +02:00
Olivier Poitrey 92d7a01a52 Perform image decoding/optimization in the IO thread instead of main thread for better responsiveness (fix #18)
This new optimization is currently disabled by default so you can test it and give us feedback.
To enable it, add #define ENABLE_SDWEBIMAGE_DECODER and to not forget to add SDWebImageDecoder class
to your projet.

Thanks to Adam Jernst (https://github.com/adamjernst) and James Tang (https://github.com/mystcolor)
for this great optimization. See https://github.com/rs/SDWebImage/pull/18 for more info.
2011-10-04 13:07:26 +02:00
Olivier Poitrey 4792909c5b Merge pull request #29 from nonamelive/patch-1
Fixed a potential crash when the delegate retainCount = 1, which means th
2011-10-03 07:18:06 -07:00
Olivier Poitrey 7d0e544c50 Add an option to disable on disk caching (fix #16) + refactor other options (low prio and retry failed) to an options: parameter 2011-10-03 15:54:49 +02:00
Olivier Poitrey 7c06b3a314 Failsafe a very common usage error (passing URL as NSString instead of NSURL) 2011-10-01 00:38:44 +02:00
nonamelive 2b0bb248f4 Fixed a potential crash when the delegate retainCount = 1, which means the delegate is only retained by the SDWebImageManager and the delegate's dealloc method has a structure like the code below.
- (void)dealloc
{
    [manager cancelForDelegate:self];
    [super dealloc];
}
2011-09-28 14:29:51 +08:00
Olivier Poitrey e9d43e443a When storeImage:imageData:forKey:toDisk: is called with toDisk:YES but no data, do not prevent memory caching (fix: #24) 2011-09-21 15:03:14 +02:00
Olivier Poitrey 1a355d09c2 Merge pull request #20 from exalted/master
Added UIButton+WebCache category
2011-07-25 11:12:18 -07:00
Ali Servet Donmez 4b00568942 Added UIButton+WebCache category 2011-07-25 17:50:21 +02:00
Adam Ernst 45cc126d32 Fix race condition with SDWebImageManager's cancelForDelegate:
The -cancelForDelegate: method was working for downloads but not local cache checks. Add some new machinery to keep track of pending cache requests and only message the delegate if it hasn't since requested cancellation.
2011-07-13 23:03:36 +02:00
Olivier Poitrey 47aad5b55f Fix some implicit conversion warnings 2011-07-13 21:55:34 +02:00
Olivier Poitrey 4005884df5 Fix coding style 2011-07-13 21:23:13 +02:00