Bogdan Poplauschi
2bb336bc12
Merge pull request #2449 from dreampiggy/feature_set_image_block_extra_args
...
Feature set image block extra args
2018-08-28 12:36:55 +03:00
Bogdan Poplauschi
6892f9e818
Merge pull request #2453 from dreampiggy/improvement_animation_class_protocol
...
Add one initializer with extra arg for custom animated image class to use possible coder options, to make it extensible
2018-08-28 12:03:06 +03:00
Bogdan Poplauschi
03ab0a937f
Merge pull request #2459 from dreampiggy/remove_sd_setAnimationImagesWithURLs
...
Remove `sd_setAnimationImagesWithURLs` API, because its cause ambiguity, behave not consistently and have rare use case.
2018-08-28 11:59:38 +03:00
DreamPiggy
7c5c114aa5
Update the comment about scale factor for coders
2018-08-28 15:21:59 +08:00
DreamPiggy
c99ddbfac9
Add one initializer with extra arg for custom animated image class to use possible coder options, to make it extensible
2018-08-28 15:09:32 +08:00
DreamPiggy
8b21041fa8
Merge pull request #2461 from zhongwuzw/add-no-expire-file-of-disk
...
Add no expiration file support of disk cache
2018-08-28 14:28:37 +08:00
zhongwuzw
9bd5c05113
Add more detaild comments of maxCacheAge and fix typo
2018-08-28 11:29:19 +08:00
DreamPiggy
9de56b013a
Merge pull request #2463 from zhongwuzw/fix-disk-size-check-for-master
...
Fix resource key invalid when clean cached disk file
2018-08-24 18:26:45 +08:00
zhongwuzw
ce27aacd7b
Fix resource key invalid when clean cached disk file
2018-08-24 17:51:30 +08:00
DreamPiggy
3ff846aa85
Merge pull request #2462 from zhongwuzw/fix-disk-size-check
...
Fix resource key invalid when clean cached disk file
2018-08-24 17:47:18 +08:00
zhongwuzw
1f3d83784c
Fix resource key invalid when clean cached disk file
2018-08-24 16:03:50 +08:00
zhongwuzw
9afbc8bf7e
Add no expiration file support of disk cache
2018-08-24 15:54:04 +08:00
DreamPiggy
349bec4497
Remove `sd_setAnimationImagesWithURLs` API, because its cause ambiguity, behave not consistently and have rare use case.
2018-08-23 15:35:38 +08:00
DreamPiggy
14391eb45e
Ignore to query disk cache when the image for FLAnimatedImageView+WebCache is placeholder
2018-08-21 14:09:02 +08:00
Bogdan Poplauschi
6246c0ea0b
Merge pull request #2452 from dreampiggy/api_protocol_property
...
Adopt all the protocol APIs which contains getter value to use property instead, to make the API easy to use or Swift user
2018-08-20 09:05:39 +03:00
DreamPiggy
8c5db9484b
Adopt all the protocol APIs which contains getter value to use property instead, to make the API easy to use or Swift user
2018-08-19 12:10:26 +08:00
Wu Zhong
5a2b9b2c51
Merge pull request #2451 from dreampiggy/fix_cache_key_filter
...
Fix the bug that `SDWebImageContextCacheKeyFilter` wrongly be used as cache serializer and cause crash
2018-08-17 21:59:01 +08:00
DreamPiggy
0fb7268d2e
Add the test case for cache serializer feature
2018-08-17 17:58:27 +08:00
DreamPiggy
b400b51cca
Fix the bug that `SDWebImageContextCacheKeyFilter` wrongly be used as cache serializer and cause crash
2018-08-17 17:20:17 +08:00
DreamPiggy
39893fbdac
Merge branch 'master' of https://github.com/rs/SDWebImage into 5.x
...
# Conflicts:
# Tests/Tests/SDCategoriesTests.m
# Tests/Tests/SDTestCase.h
# Tests/Tests/SDTestCase.m
2018-08-17 16:19:09 +08:00
DreamPiggy
8f5cba5708
Merge pull request #2416 from bpoplauschi/update_contributing
...
Added a bit more description to the way to contribute to this project.
2018-08-17 15:35:35 +08:00
DreamPiggy
3966200d6a
Merge pull request #2434 from dreampiggy/test_coder
...
Add more tests for image decoding/encoding part
2018-08-17 14:56:39 +08:00
DreamPiggy
26ebbba807
Merge pull request #2438 from dreampiggy/test_view_category
...
Add the test cases for View Transition and View Indicator, both iOS && macOS
2018-08-17 14:46:42 +08:00
DreamPiggy
a794088bc7
Revert the hack code for FLAnimatedImage compatible, because of the FLAnimatedImage initializer method block main queue.
2018-08-16 22:51:57 +08:00
Bogdan Poplauschi
07d3d1eb6e
Merge pull request #2450 from dreampiggy/fix_testcase
...
Fix the test case testFLAnimatedImageViewSetImageWithURL because of remote resource is not available
2018-08-16 17:42:15 +03:00
DreamPiggy
50b6a09a9b
Fix the test case testFLAnimatedImageViewSetImageWithURL because of remote resource is not available
2018-08-16 14:57:47 +08:00
DreamPiggy
04becbb02b
Update the test to ensure the UIView sd_internalSetImageWithURL of setImageBlock behavior
2018-08-16 11:45:51 +08:00
DreamPiggy
a6a8308c15
Change the View Category setImageBlock with all args like View Transition or CompletedBlock, to make it useful for advanced usage
2018-08-16 11:32:12 +08:00
DreamPiggy
8b26091741
Disable HEIC encoding check temporally for travis-ci
2018-08-10 23:49:35 +08:00
DreamPiggy
0ff95e2255
Update the view indicator and transition test
2018-08-10 23:25:17 +08:00
Bogdan Poplauschi
5ea8074bad
Merge pull request #2399 from zhongwuzw/replace-valueforkey
...
Replace valueForKey with objectForKey when access NSDictionary
2018-08-10 18:19:59 +03:00
zhongwuzw
30d077b0a6
Make callbacks of download more readable
2018-08-10 22:53:13 +08:00
DreamPiggy
1d8454d356
Fix that the minimumProgressInterval should always callback the final finished progress but not ignore it
2018-08-10 22:41:22 +08:00
DreamPiggy
7ee0d06cf7
Add the test cases for View Transition and View Indicator, both iOS && macOS
2018-08-10 22:36:51 +08:00
Bogdan Poplauschi
64a2453527
Merge pull request #2437 from dreampiggy/bugfix_view_progress_indicator
...
Fix the bug that progress indicator on macOS stop at 1% but not 100% when download finished
2018-08-10 17:35:07 +03:00
Bogdan Poplauschi
13207dd986
Merge pull request #2435 from dreampiggy/bugfix_progressive_race_condition
...
Fix a race condition during progressive animation load in SDAnimatedImageView
2018-08-10 17:25:43 +03:00
DreamPiggy
41b0a0421e
Fix the mistake cause a bug that progress indicator on macOS stop at 1% but not 100% when download finished...
2018-08-10 22:05:35 +08:00
DreamPiggy
5ea4b803d0
Update travis-ci Xcode version to 9.4, fix HEIF/HEIC coder test
2018-08-10 15:51:37 +08:00
DreamPiggy
bbee2976af
Merge pull request #2433 from zhongwuzw/fix-cache-migration
...
Fix cache migration when dstPath intermediate directories not exist
2018-08-10 15:49:11 +08:00
DreamPiggy
7187aff159
Update SDAnimatedImage test and HEIC/HEIF test
2018-08-10 15:41:32 +08:00
DreamPiggy
b0775361b5
Add more test about SDAnimatedImage
2018-08-10 15:26:14 +08:00
DreamPiggy
8bd5e5e44d
Add more tests for animated coder
2018-08-10 15:26:14 +08:00
DreamPiggy
fc23b93d08
Update the test about progressive decoding of other image format
2018-08-10 15:26:14 +08:00
DreamPiggy
3cd71e09ce
Merge branch 'master' of https://github.com/rs/SDWebImage into 5.x
...
# Conflicts:
# SDWebImage/NSData+ImageContentType.h
# SDWebImage/SDWebImageDownloader.m
# SDWebImage/SDWebImageImageIOCoder.m
2018-08-10 15:20:55 +08:00
DreamPiggy
6e79ef51f0
Fix a race condition during progressive animation load in SDAnimatedImageView.
...
When the coder was updated, currentData may not be the same instance as previousdData. We should check the that current data is appended by previous data
2018-08-10 13:19:27 +08:00
zhongwuzw
3a22bcff58
Fix cache migration when dstPath intermediate directories not exist
2018-08-10 09:00:34 +08:00
Bogdan Poplauschi
802e19b23d
Merge pull request #2426 from zhongwuzw/remove-notification-dispatch
...
Make download receive response notification only dispatch to specific observer
2018-08-09 17:41:58 +03:00
zhongwuzw
9a63520115
Remove NS_DESIGNATED_INITIALIZER macro
2018-08-09 20:43:35 +08:00
zhongwuzw
22a8c43bca
Put download token init internal
2018-08-09 17:21:24 +08:00
zhongwuzw
65f72743cc
Merge branch '5.x' into replace-valueforkey
2018-08-09 15:41:29 +08:00