Commit Graph

2614 Commits

Author SHA1 Message Date
DreamPiggy b444652412 Add more tests to ensure the callback been called, even we cancel the operation, impact the view category and prefetcher 2019-08-03 17:24:34 +08:00
DreamPiggy 54b6d9d3f8
Merge pull request #2802 from RomanPodymov/master
Add missing nullable and nonnull attributes
2019-08-02 18:35:50 +08:00
DreamPiggy 4e51f1deac Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into bugfix_user_cancel_guarantee_callback 2019-08-02 17:41:32 +08:00
DreamPiggy f5980e5fed
Merge pull request #2801 from dreampiggy/feature_ensure_image_class_match
Add a new option `SDWebImageMatchAnimatedImageClass`, to ensure we always match the custom image class instead of UIImage/NSImage class
2019-08-02 17:29:23 +08:00
DreamPiggy 00ed3fd1c7 Update the comments 2019-08-02 16:40:31 +08:00
DreamPiggy cd2e36f7a5 Add test cases for `matchAnimatedImageClass` options 2019-08-02 16:03:48 +08:00
DreamPiggy 43bb20af32 Using isSubclassOfClass instead == for animated image class matching check 2019-08-02 15:46:44 +08:00
DreamPiggy 95ed9e1576 A little coding style fix for block invoke 2019-08-02 13:34:42 +08:00
DreamPiggy 67b29b9d07 Update all the test cases for cancel, now it should receive a completion with error code `SDWebImageErrorCancelled` 2019-08-02 13:32:08 +08:00
DreamPiggy 0dfbc233d8 Fix the cancel logic for download operation, because now we always callback your completion even it's cancelled 2019-08-02 13:30:24 +08:00
Roman Podymov e8e7b5fa00
Update UIImage+Transform.m 2019-08-02 00:03:20 +02:00
Roman Podymov 3d2f2fc2e0
Update UIImage+Transform.m 2019-08-02 00:00:35 +02:00
Roman Podymov 34fa90c7c5
Update UIImage+Transform.m 2019-08-01 23:57:38 +02:00
Roman Podymov 9cf6b6d6ce
Update NSImage+Compatibility.m 2019-08-01 20:12:32 +02:00
Roman Podymov dcf953d03a
Update UIImage+ForceDecode.m 2019-08-01 20:05:54 +02:00
DreamPiggy 6f0f735d4f Update the test case for cancel behavior 2019-08-01 20:12:07 +08:00
DreamPiggy 5b1a833732 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into bugfix_user_cancel_guarantee_callback 2019-08-01 20:05:48 +08:00
DreamPiggy 4e7d03d471 Add a new option `SDWebImageMatchAnimatedImageClass`, to ensure we always match the custom image class instead of UIImage/NSImage class. This may help for some rare case that user always need the specify image subclass (SDAnimatedImage) for their imageView (SDAnimatedImageView) instead of the built in one. 2019-08-01 19:54:52 +08:00
DreamPiggy f49c4fa483
Merge pull request #2799 from dreampiggy/update_readme_installation
Update the readme about Swift Package Manager and xcframework installation guide
2019-07-30 12:34:28 +08:00
DreamPiggy 3f7a3a8035 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into bugfix_user_cancel_guarantee_callback 2019-07-30 11:52:04 +08:00
DreamPiggy d6938fce7b update the readme about the manual install 2019-07-29 18:41:21 +08:00
kinarob 25c6cdf570 some typo in readme 2019-07-29 17:45:05 +08:00
DreamPiggy 7f1b5f05a2 Update the readme about Swift Package Manager and xcframework installation guide 2019-07-29 16:44:01 +08:00
DreamPiggy 09f06159a3
Merge pull request #2797 from dreampiggy/fix_swift_pm
Fix SwiftPM integration issue on Xcode 11 beta
2019-07-28 12:48:06 +08:00
DreamPiggy 99857f346d Fix SwiftPM build issue, by moving all the Core source files && headers, into SDWebImage/Core, which is used as public headers directory 2019-07-25 18:42:05 +08:00
DreamPiggy b7b3d3d0c2 Fix the Swift PM build issue 2019-07-23 15:02:40 +08:00
DreamPiggy 6d4e166b8b Change current behavior. All the user cancelled code will trigger the callback (including both cache && download). The error code name changed to `SDWebImageErrorCancelled` to represent both cases 2019-07-19 18:07:41 +08:00
DreamPiggy 841662d36a
Merge pull request #2792 from kinarobin/add_autoreleasepool_in_prefetcher
Add a autoreleasepool when prefetch many images
2019-07-19 11:34:41 +08:00
kinarob d51b9e6802 add a autoreleasepool when prefetch many images 2019-07-18 18:53:57 +08:00
DreamPiggy a2b3a57bb2 Change the lock into @synchronized to ensure the operation callback is always get attached correctly, avoid the callback is not get called 2019-07-18 17:42:44 +08:00
DreamPiggy f2fb26d1c6 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into bugfix_user_cancel_guarantee_callback 2019-07-18 16:12:35 +08:00
DreamPiggy 834ce0875d
Merge pull request #2789 from kinarobin/create_weak_cache_only_apply_to_iOS/tvOS_platform
Only create weak cache in iOS/tvOS platform.
2019-07-12 11:26:29 +08:00
kinarob f319864dd8 Just crete weak cache in iOS/tvOS platform 2019-07-12 10:09:38 +08:00
DreamPiggy 2d62616cb0
Merge pull request #2782 from kinarobin/fix_frame_buffer_bug_when_displayLink_is_pause
Fix frame buffer bug when display link is pause
2019-07-09 23:33:00 +08:00
kinarob 9fa869c40b get fetch queue via instance 2019-07-09 15:14:57 +08:00
Kinarobin 5e2bdc60a7
Merge pull request #2785 from dreampiggy/bugfix_uibutton_convenient_method
Fix the bug that UIButton setBackgroundImage convenient method does not pass the options arg to next function call
2019-07-08 19:21:27 +08:00
DreamPiggy fc3382591a Fix the bug that UIButton setBackgroundImage convenient method does not pass the options arg to next function call, cause the options miss. 2019-07-08 18:46:10 +08:00
kinarob 7605053cf5 fix frame buffer bug when display link is pause 2019-07-05 21:14:03 +08:00
DreamPiggy 5df70628be
Merge pull request #2780 from dreampiggy/project_upgrade_xcode_10
Follow App Store submit rule, upgrade the minimum Xcode version to Xcode 10.0
2019-07-03 16:45:56 +08:00
DreamPiggy 1bd110c974
Merge pull request #2764 from dreampiggy/feature_support_build_xcframework_script
Provide a script target to directly build all SDWebImage framework and generate all in one XCFramework from Xcode 11
2019-07-03 16:45:03 +08:00
DreamPiggy 9f2db8701a
Merge pull request #2779 from dreampiggy/expose_memory_disk_cache_object
Expose the memoryCache and diskCache object on `SDImageCache`, Make it useful for user who have custom property beyond `SDImageCacheConfig`
2019-07-03 11:42:27 +08:00
DreamPiggy 5c22cc73ae Update the project warning for unnecessary xcconfig files 2019-07-02 18:23:39 +08:00
DreamPiggy 6ba2640ca4 Update the storyboard with Xcode 10.2 version format 2019-07-02 18:20:12 +08:00
DreamPiggy 712e12e23a Follow App Store submit rule, upgrade the min Xcode version to Xcode 10.0 2019-07-02 18:17:15 +08:00
DreamPiggy 6d626edaf8 Expose the memoryCache and diskCache object on `SDImageCache`, make it useful for user who have custom property beyond `SDImageCacheConfig` 2019-07-02 15:12:56 +08:00
DreamPiggy 049feda30a
Merge pull request #2713 from bpoplauschi/remove_explicit_Tests_deployment
Revert explicitly set *_DEPLOYMENT_TARGET inside the Tests Xcode project
2019-06-30 13:01:34 +08:00
DreamPiggy 3cd71190b3 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into remove_explicit_Tests_deployment 2019-06-30 12:07:16 +08:00
DreamPiggy 559e0e868b
Merge pull request #2775 from dreampiggy/fix_SDAnimatedImage_documentation
Fix the documentation about SDAnimatedImage.animatedImageData to match its behavior
2019-06-28 16:56:21 +08:00
DreamPiggy 6654050005 Fix typo 2019-06-28 16:29:59 +08:00
DreamPiggy 4c3a055f53 Fix the documentation about SDAnimatedImage.animatedImageData to match its behavior 2019-06-28 15:32:31 +08:00