DreamPiggy
9021e5b002
Change access the imageData in NSURLSession delegate queue to solve non thread-safe issue. Also, ensure imageData in completion block is immutable to avoid accident modification from the other queue
2017-08-31 21:04:17 +08:00
Bogdan Poplauschi
e4ab5ebce2
Merge pull request #2002 from iwill/master
...
Fix issue #2001 , add sd_currentBackgroundImageURL and sd_backgroundIm…
2017-08-18 21:54:35 +03:00
iwill
de897ae33a
Fix issue #2001
2017-08-18 13:55:34 +08:00
iwill
80dace4a4a
Fix issue #2001 , add sd_currentBackgroundImageURL and sd_backgroundImageURLForState: for UIButton
2017-08-18 12:02:06 +08:00
Bogdan Poplauschi
94cdb773d7
Merge pull request #1995 from DwayneCoussement/strict-prototype
...
CLANG_WARN_STRICT_PROTOTYPES: Yes please!
2017-08-15 10:55:40 +03:00
Dwayne Coussement
4d99ca6c86
CLANG_WARN_STRICT_PROTOTYPES: Yes please!
2017-08-14 15:05:46 +02:00
Bogdan Poplauschi
79124e1bab
Revert "Update for cache policy calculation: I think that if SDWebImageDownloaderIgnoreCachedResponse is there, we need NSURLRequestReloadIgnoringLocalCacheData so we always reload."
...
This reverts commit ae75b747b0
.
2017-08-11 18:00:59 +03:00
Bogdan Poplauschi
ae75b747b0
Update for cache policy calculation: I think that if SDWebImageDownloaderIgnoreCachedResponse is there, we need NSURLRequestReloadIgnoringLocalCacheData so we always reload.
2017-08-11 17:18:31 +03:00
Bogdan Poplauschi
7b79c29a8c
The docs say the progressBlock is called on a background queue, so when doing UI, we need to dispatch on the main queue
...
* @param progressBlock A block called while image is downloading
* @note the progress block is executed on a background queue
2017-08-11 16:38:32 +03:00
Bogdan Poplauschi
ecdd0128ab
Fixed #1993 Load image with option `SDWebImageRefreshCached` get error
...
#1737 introduced an issue that is using NSURLRequestReturnCacheDataDontLoad for our cached images which makes us never download again, which is not ok when using `SDWebImageRefreshCached`.
Fixed by reverting to the original implementation here: `NSURLRequestUseProtocolCachePolicy` vs `NSURLRequestReloadIgnoringLocalCacheData` (when `SDWebImageRefreshCached` is set)
2017-08-11 16:37:29 +03:00
Bogdan Poplauschi
2f892f968f
Attempt to fix #1883 by using a weakSelf reference to remove from callbackBlocks (on the barrierQueue)
2017-08-08 13:19:20 +03:00
Bogdan Poplauschi
4cfb2e4b9f
Merge pull request #1984 from dreampiggy/fix_unreachable_code
...
Fix unreachable code build warning on macOS
2017-08-04 19:39:56 +03:00
DreamPiggy
65548e3650
Fix unreachable code warning
...
Fix unreachable code warning because of the return and break expression in #if SD_MAC
2017-08-04 22:37:38 +08:00
Bogdan Poplauschi
6e70dbc5ad
Merge pull request #1980 from skyline75489/feature/sdtestcase
...
Move common test logic to SDTestCase
2017-08-03 12:51:55 +03:00
skyline75489
d11597a796
Move common test logic to SDTestCase
2017-08-03 07:50:51 +08:00
Bogdan Poplauschi
cd84881ff8
Merge pull request #1977 from skyline75489/fix/use-foundation-export
...
Use FOUNDATION_EXPORT over extern
2017-08-02 15:15:03 +03:00
Bogdan Poplauschi
ff3b4ac9fd
Merge pull request #1978 from dreampiggy/fix_CFRelease_crash
...
Fix CFRelease on NULL if CGImageSourceRef create failed
2017-08-02 14:45:27 +03:00
Bogdan Poplauschi
a4a5e018c4
Merge pull request #1976 from dreampiggy/fix_CGBitmapContextCreate_memory_leak
...
Fix CGBitmapContextCreate bitmap memory leak issue
2017-08-02 14:15:04 +03:00
DreamPiggy
c7a444f4a7
Fix CFRelease on NULL if CGImageSourceRef create failed
...
Fix CFRelease on NULL if CGImageSourceRef create failed, this may happen on progressive download with wrong image data
2017-08-02 17:24:13 +08:00
skyline75489
0f387c6694
Use FOUNDATION_EXPORT over extern
2017-08-01 07:14:48 +08:00
DreamPiggy
5e367af7b5
Fix CGBitmapContextCreate bitmap memory leak issue
...
Pass NULL to CGBitmapContextCreate whenever the data param is not used later to reduce memory leak issue
2017-08-01 01:34:21 +08:00
Bogdan Poplauschi
49772b3bc9
Updated Readme.md added dreampiggy to the team
2017-07-31 18:36:11 +03:00
Bogdan Poplauschi
1f4f371a7a
Bumped libwebp submodule reference to version 0.6.0
2017-07-31 16:28:02 +03:00
Bogdan Poplauschi
2d9c81295f
Bumped version to 4.1.0, updated changeling
2017-07-31 16:08:03 +03:00
Bogdan Poplauschi
f6cca301d5
Merge pull request #1952 from dreampiggy/master
...
#1951 : Fix animated WebP decoding issue, including canvas size, the support for dispose method and the duration per frame
2017-07-31 15:26:06 +03:00
Bogdan Poplauschi
b0cf9d6c57
Merge pull request #1452 from sean9keenan/fixedOutOfOrderImages
...
Fixed issue where animated image arrays could be populated out of order
2017-07-31 15:20:41 +03:00
Bogdan Poplauschi
3d7b6c1bf6
Merge pull request #1975 from dreampiggy/mac_animate_gif
...
support animated GIF on macOS
2017-07-31 14:26:02 +03:00
Bogdan Poplauschi
d9f7cf417b
Fixed #1776 Umbrella header warning for the FLAnimatedImage (while using Carthage) - replaces #1781
2017-07-31 14:19:02 +03:00
Bogdan Poplauschi
637c418139
Removed unreliable check from Downloader tests - sometimes there is more than 1 download in the queue which makes the tests fail
2017-07-31 13:02:26 +03:00
DreamPiggy
886b857e8a
Merge branch 'master' of https://github.com/rs/SDWebImage
...
# Conflicts:
# SDWebImage/SDWebImageCompat.m
2017-07-29 22:34:59 +08:00
DreamPiggy
bd78863888
Improve Animated WebP decoder robustness and fix warning
...
Only decode the first frame on macOS
Fix CGBitmapContextCreate failed issue
Duration set to 100ms if it’s lower or equal than 10ms for compatibility
Fix unused variable warning for macOS
2017-07-29 22:32:38 +08:00
DreamPiggy
fecf4d28fd
support animated GIF on macOS
...
use NSImage built-in method to maintain GIF on macOS
update README
2017-07-29 21:26:38 +08:00
Bogdan Poplauschi
3c64b81ac1
Merge pull request #1971 from kekeYezi/master
...
Small change - coding style
2017-07-28 21:17:09 +03:00
Daniel
a4751a652f
Small change
...
Small change
2017-07-28 21:16:22 +03:00
Bogdan Poplauschi
4da40ac853
Merge pull request #1891 from Westacular/1870_Change_NSURLSessionConfiguration
...
Add ability to change NSURLSessionConfiguration used by SDWebImageDownloader
2017-07-28 21:08:46 +03:00
Bogdan Poplauschi
8ac72a2bdb
Merge pull request #1797 from skyline75489/quick-fix-for-swift3
...
Fix #1764 Swift naming collision
2017-07-25 17:04:46 +03:00
Bogdan Poplauschi
dbb2dcd2b5
Merge pull request #1940 from joshuafeldman/master
...
#1807 - #1821 - Fixing incorrectly retained pointer to self which app…
2017-07-24 21:29:29 +03:00
Bogdan Poplauschi
83528027a7
Merge pull request #1966 from github641/patch-1
...
spelling correction
2017-07-24 21:22:25 +03:00
Bogdan Poplauschi
add6fc8fa3
Merge pull request #1911 from disaabler/master
...
#1909 : Crash on multiple concurrent downloads when accessing self.URLOperations dictionary
2017-07-24 20:59:02 +03:00
Bogdan Poplauschi
a02d51cf80
Merge pull request #1946 from rafaelks/chore/update_cocoapods_script
...
Update CocoaPods script to use latest version of the lib (4.0 instead of 3.8)
2017-07-24 20:52:35 +03:00
mrliuzy
56325ab268
spelling correction
...
spelling correction
2017-07-19 15:40:02 +08:00
DreamPiggy
e3ed82fdda
Add animated WebP loop count and fix duration zero issue
...
Animated WebP image support loop count. Set this value to UIImage decoded with WebP data.
Frame duration set to 100ms if is zero
2017-07-03 15:00:55 +08:00
DreamPiggy
f3cffd0aca
Add test for animated WebP image array
...
The image array used for +[UIImage animatedImageWithImages:] should share the same size.
2017-07-03 02:46:42 +08:00
DreamPiggy
a907114b19
Fixed animated webp decoder issue when image has different duration per frame
...
Animated webp can set duration per frame but the UIImage animate array just use the average duration for each frame
2017-07-03 02:36:57 +08:00
DreamPiggy
bb0c882392
Add support to animted WebP dispose method
...
dispose method is widely used in animated WebP images and should add support
2017-06-30 13:49:56 +08:00
DreamPiggy
f3bd1071f5
Fixed CGContextBitmapCreate bitmapInfo and fix typo
...
Fixed CGContextBitmapCreate with wrong bitmapInfo if has no alpha channel
Rename sd_rawWepImageWithData to sd_rawWebpImageWithData
2017-06-30 13:48:43 +08:00
DreamPiggy
1018953b99
Fixed animated WebP image frame size wrong
...
Fix animated WebP image decoder bug causing rendering canvas in current canvas size context but not image size context for multiple frame.
2017-06-30 13:47:00 +08:00
Rafael Kellermann Streit
fa30b4bda3
Update CocoaPods script to use latest version
2017-06-23 10:23:06 -03:00
Joshua Feldman
1f33e95aa6
#1807 - #1821 - Fixing incorrectly retained pointer to self which appears to create a dangled pointer
2017-06-20 13:10:05 -07:00
Eugene Dudnyk
cf963c06c3
#1909 : Crash on multiple concurrent downloads when accessing self.URLOperations dictionary.
2017-05-21 12:49:03 +02:00