Commit Graph

993 Commits

Author SHA1 Message Date
Olivier Poitrey d2da4d0df4 Merge pull request #929 from kirualex/patch-2
Handle empty urls NSArray
2014-10-14 07:14:45 -07:00
Alexis Creuzot 98082a6791 Handle empty urls NSArray
In some cases the user may end up with an empty urls NSArray, in which case the completion block is never called.
This commit handle such case to call immediately the completion block (if any)
2014-10-14 11:16:58 +02:00
Bogdan Poplauschi 2233b5e77d Merge pull request #896 from skrew/master
Update UIImageView+WebCache.m
2014-09-22 22:23:19 +03:00
Bogdan Poplauschi ee3c351abd Fixed #900 by adding a new flag SD_LOG_NONE that allows silencing the SD logs from the Prefetcher 2014-09-22 22:15:45 +03:00
Matt Galloway 66a6873b2c Switch to built in XCTest async 2014-09-15 12:06:11 +01:00
eric@skrobs 54a772ebb9 Update UIImageView+WebCache.m
Can cause animation losing or crash if you are in a thread.
2014-09-12 20:03:34 +02:00
Bogdan Poplauschi 5f4d7f44b4 Merge pull request #893 from asparagui/sp_fixes
minor spelling (forth->fourth)
2014-09-12 09:45:33 +03:00
Brett Koonce 5284ac6623 minor spelling (forth->fourth) 2014-09-11 19:24:54 -07:00
Bogdan Poplauschi 43af50c555 Merge pull request #890 from kyleclegg/master
Updated key filter sample code
2014-09-11 09:41:42 +03:00
Kyle Clegg 013ccba57b Updated code sample to not use deprecated api 2014-09-10 12:51:25 -06:00
John C. Daub 3c82278727 atomicity was implicit (compiler complained). Declared 'nonatomic' as that's fairly standard on iOS 2014-09-04 09:08:47 -05:00
Bogdan Poplauschi 11125c4379 Merge pull request #879 from dulgan/patch-1
Adding a flag for Cocoa Pods users
2014-09-01 16:09:36 +03:00
dulgan 249adae4f0 Adding a flag for Cocoa Pods users
Using the Parse framework and SDWebImage frameworks installed via Cocoa Pods gives the same error as described in the Alternatively section of the Add Linker Flag section in this Readme.
I found a solution here : http://www.deanmao.com/2012/12/31/linker-error-using-cocoapods/
2014-08-27 14:10:27 +02:00
Matias Pequeno 3671cdde0f Adds setter to override default SDWebImageDownloaderOperation. 2014-08-14 18:12:37 -07:00
Bogdan Poplauschi 6dfec7ccd9 Updated README.md with CocoaDocs link 2014-08-12 13:59:40 +03:00
Bogdan Poplauschi 15cda1b561 Merge pull request #854 from Gabro/patch-1
More explicit error message in case of nil completedBlock
2014-08-12 12:26:01 +03:00
Gabriele Petronella ec6b6e7267 More explicit error message in case of nil completedBlock
NSParameterAssert doesn't provide enough information for understanding the API misuse.
Pointing the API user to SDWebImagePrefetcher makes more sense, as a nil completedBlock most likely signifies the intention of prefetching the image.
2014-08-12 11:23:31 +02:00
Bogdan Poplauschi 16eea9f104 Updated references to libwebp files after the changes from their latest release (0.4.1) 2014-08-11 15:00:19 +03:00
Bogdan Poplauschi 8bf39a9263 Merge pull request #850 from tonyarnold/fix-comment-documentation
Fix misnamed parameters in comment documentation
2014-08-11 10:31:45 +03:00
Tony Arnold a31b9d46a1 Fix misnamed parameters in comment documentation 2014-08-11 17:27:05 +10:00
Bogdan Poplauschi f1041856d0 Updated libwebp reference to 0.4.1 (this fixed the arm64 build issues) 2014-08-08 18:12:59 +03:00
Bogdan Poplauschi 044abf402d Merge pull request #838 from justjimmy/master
fix cancelAll crash (Issue #809)
2014-08-06 19:20:47 +03:00
Bogdan Poplauschi 55c7c6c8e1 Merge pull request #703 from talklittle/master
Flag to transform animated images
2014-08-04 11:47:06 +03:00
Andrew Shu a8c4fa48b7 Flag to transform animated images
Using a new SDWebImageOptions flag: SDWebImageTransformAnimatedImage
2014-08-04 01:42:12 -07:00
foxling b2909fb2da fix #610 2014-08-04 15:17:58 +08:00
Jimmy Lee 3587b8d1e0 fix cancelAll crash 2014-07-31 10:10:52 +10:00
Bogdan Poplauschi 2eef774eae Merge pull request #836 from reiz/master
Add Reference & Dependency Badges
2014-07-28 13:47:42 +03:00
Robert Reiz bf6be426f3 Add References Badge to Readme 2014-07-26 10:45:46 +02:00
Robert Reiz 934c9cc96d Add Dependency Badge 2014-07-26 10:44:56 +02:00
Bogdan Poplauschi 7815923c48 Fixed other misspells from appledoc (additions to #829) 2014-07-23 16:15:16 +03:00
Bogdan Poplauschi 101ee70d94 Merge pull request #829 from davemess/master
Fix documentation spelling
2014-07-23 16:12:02 +03:00
David Messing 3bb13ef34a Merge branch 'branch-misspell' 2014-07-23 09:00:03 -04:00
David Messing b9d9456e21 Fixed documentation spelling. 2014-07-23 08:59:52 -04:00
Bogdan Poplauschi 959e8db914 Bumped podspec version 2014-07-23 08:17:14 +03:00
Bogdan Poplauschi e95224bf5f Temporary fix for #809, until we can figure out the cause of the crash 2014-07-23 08:13:25 +03:00
Bogdan Poplauschi f96302b427 Merge pull request #827 from BB9z/fix/pargma-mark
Missing mark.
2014-07-22 12:17:09 +03:00
BB9z f6d7d60b98 Missing mark. 2014-07-22 16:58:08 +08:00
Bogdan Poplauschi 222e6bca0d Merge pull request #795 from xlchen/master
fix duplicate symbols when using with webp via pods
2014-07-21 15:32:45 +03:00
Bogdan Poplauschi 28109c4c70 Fixed SDWebImageCombinedOperation cancel crash (#798 #809) 2014-07-21 15:27:16 +03:00
mishagray 7d93374067 Modified the cost calculuations to appropriately compute the 'scale' of an image 2014-07-20 18:10:02 -04:00
Bogdan Poplauschi c8df858f75 Added test for the UIImage+MultiFormat crash 2014-07-18 16:56:32 +03:00
Bogdan Poplauschi 681a7c4222 Merge pull request #819 from n13/master
guarding against image source == NULL
2014-07-18 16:21:16 +03:00
Nikolaus Heger 9faee5356c guarding against image source == NULL 2014-07-18 11:07:13 +07:00
Bogdan Poplauschi b88a552fba Updated all block params and properties, using defined blocks that have var names (for proper autocomplete). Created a SDWebImageNoParamsBlock to distinguish easier from other no params blocks. Fixes #810 2014-07-16 15:17:08 +03:00
Bogdan Poplauschi cd4b925448 Update to #732 to fix misspell (completion instead of completition) 2014-07-14 18:29:45 +03:00
Bogdan Poplauschi db252d3654 Updated podspec version to 3.7.0 2014-07-14 18:12:07 +03:00
Bogdan Poplauschi f080e38fb8 Replace #699 Fixed race condition in SDWebImageManager if one operation is cancelled, the completion block must not be called, otherwise it might race with a newer completion for the same object
Conflicts:
	SDWebImage/SDWebImageManager.m
2014-07-14 16:29:57 +03:00
Bogdan Poplauschi 6e4fbafa55 #625 In order to fix the deadlock, reviewed the `[SDImageCache diskImageExistsWithKey:]` method. Based on the Apple doc for NSFileManager, using the defaultManager without the dispatch on the ioQueue to avoid the deadlocks. This instance is thread safe. Also created an async variant of this method `[SDImageCache diskImageExistsWithKey:completion:]`
For consistency, added async methods in `SDWebImageManager` `cachedImageExistsForURL:completion:` and `diskImageExistsForURL:completion:`
2014-07-14 16:22:00 +03:00
Bogdan Poplauschi 0b47342b2f No need for explicit ivar and getters, as long as we have the @synthesize in place 2014-07-14 13:01:05 +03:00
Bogdan Poplauschi 39db378082 Merge pull request #783 from bpoplauschi/race_condition
Replace #621Fixed race condition between operation cancelation and loading finish
2014-07-11 09:57:28 +03:00