Jens Andersson
fbe3b95e8c
Added new option to allow invalid SSL Certificates. Useful for testing
2013-12-11 13:31:03 +01:00
Bogdan Poplauschi
b201e137d8
Added PNG detection to be able to determine at runtime if a downloaded image should be saved as PNG or as JPEG
2013-12-11 12:15:05 +01:00
Erik Charlebois
3f20a101c5
Fix race condition in image download cancellation
...
There are many race conditions around cancelling
SDWebImageDownloaderOperation instances from other threads. For example,
imageData may be set to nil and deallocated just as it is being appended
to, or the threading can interleave in such a way that messages are sent
to a deallocated connection. These were discovered using SDWebImage for
a Google Maps-style tiled mapping application where there is a lot of
download and cancellation if users pan rapidly.
This fix tracks the worker thread that the NSURLConnection instance runs on and
performs cancellation on the worker thread. The cancel and start methods need
to be synchronized to handle the case where cancellation happens before
start is called; since no thread has been assigned yet, cancellation is
performed on the calling thread.
Because cancellation is now scheduled on the same run loop as
NSURLConnectionDelegate callbacks, there is an added window of time that
a download can finish prior to cancellation. This means it's possible to
cancel an operation yet still get a successful completion callback. This
was always possible because of race conditions, but it is more
pronounced and predictable now. An application that relies on
a cancelled operation never calling its completion block (e.g. recycling
image views in a scrolling table view) must adopt some other mechanism
(e.g. a version number) to avoid running completion code for a stale operation.
2013-12-09 17:08:56 -05:00
Vincent Pizzo
8a541f6f31
bleh
2013-12-09 15:58:32 -06:00
Vincent Pizzo
716fc38c93
Updating podspec
2013-12-09 15:54:44 -06:00
Vincent Pizzo
4335fb7e41
Using webkit's method for determing frame durations of various gif images
2013-12-06 16:51:31 -06:00
Olivier Poitrey
3380e56a7d
Merge pull request #577 from pieterclaerhout/master
...
Added a delegate for the web image prefetched.
2013-12-06 07:57:44 -08:00
Pieter Claerhout
51be4e298c
Code cleanup.
2013-12-06 16:53:22 +01:00
Pieter Claerhout
1a917d8239
Added a delegate for the web image prefetched.
2013-12-06 16:21:00 +01:00
Olivier Poitrey
6878fba926
Bump version to 3.5.1 ( fix #568 )
2013-12-03 00:07:28 -08:00
Olivier Poitrey
1872fed8f0
Merge pull request #562 from mknippen/master
...
added currentDownload Count, to allow someone to see how many operations are left.
2013-11-26 19:34:49 -08:00
Matthew Knippen
d0f8571dd2
matched coding conventions
2013-11-26 21:29:10 -06:00
Matthew Knippen
d020aea02f
added currentDownload Count, to allow someone to see how many operations are left.
2013-11-26 16:54:59 -06:00
Olivier Poitrey
75a76d983a
Merge pull request #514 from crazytonyli/header-picking
...
Add HTTP header passing test to pick header for downloading request
2013-11-24 22:28:19 -08:00
Tony Li
597a70a8b6
Add HTTP header filter to pick headers for downloading request
2013-11-25 14:21:42 +08:00
Olivier Poitrey
1e20c3bd07
Merge pull request #558 from shifu/master
...
up version 3.5 in podspec to be consistent with latest
2013-11-22 17:23:14 -08:00
Chang Luo
d6d4a3c3db
up version 3.5 in podspec to be consistent with latest
2013-11-22 17:18:29 -08:00
Olivier Poitrey
2043094ab5
Merge pull request #556 from JoshuaGross/master
...
Allow setting a custom memory cost limit for the in-memory NSCache.
2013-11-22 16:46:16 -08:00
Joshua Gross
c3ee589681
NSInteger -> NSUInteger, add getter method
2013-11-22 16:38:18 -08:00
Joshua Gross
c7f2665d05
Allow setting a custom memory cost limit for the in-memory NSCache. This can help to keep memory down before memory warnings are sent by the device.
2013-11-22 16:16:03 -08:00
Olivier Poitrey
417feed2ca
Merge pull request #553 from danpe/master
...
Added SDWebImageOption to enable Cookies Handling.
2013-11-18 15:56:52 -08:00
Dan Peleg
d08d63fadd
Added SDWebImageOption to enable Cookies Handling.
2013-11-18 17:18:58 -05:00
Olivier Poitrey
8b63e9ac06
Merge pull request #552 from garnett/master
...
Use UIImagePNGRepresentation to preserve transparency (fix for #545 )
2013-11-08 22:37:53 -08:00
Olivier Poitrey
2184e301c8
Merge pull request #551 from robertmryan/master
...
SDWebImagePrefetcher should only perform `NSLog` statements if `SD_VERBOSE` is defined
2013-11-08 20:51:25 -08:00
robertmryan
8b0bd16f18
Only perform `NSLog` statements if `SD_VERBOSE` is defined
2013-11-08 23:03:41 -05:00
Denis Lebedev
ae4ecb16f6
Use UIImagePNGRepresentation to preserve transparency
2013-11-04 14:36:34 +03:00
Olivier Poitrey
e5b05c3109
Merge pull request #539 from sibljon/patch-1
...
Update argument list for example in README
2013-10-27 10:37:50 -07:00
Jonathan Sibley
00c200b8c1
Update argument list for example in README
2013-10-27 09:53:00 -07:00
Olivier Poitrey
3645b6f41b
Merge pull request #537 from raylillywhite/patch-1
...
Fix link to "Who Uses SDWebImage" wiki page
2013-10-25 13:41:14 -07:00
Ray Lillywhite
1d6ace1886
Fix link to "Who Uses SDWebImage" wiki page
2013-10-25 10:20:34 -07:00
Olivier Poitrey
8830781f8f
Merge pull request #534 from pixable/ios-background
...
iOS Background: Provide background option through the manager
2013-10-23 11:29:55 -07:00
Luis Solano Bonet
81d6bf91a9
Provide background option through the manager
2013-10-23 14:20:12 -04:00
Luis Solano Bonet
c79e6ffe04
Add option to continue download in background
2013-10-22 15:21:30 -07:00
Olivier Poitrey
5df0eafc92
Fix WebP target
2013-10-04 11:43:27 -07:00
Olivier Poitrey
94f51343b8
Merge pull request #522 from redhand/master
...
Removed strong reference to UIImageView in nested block
2013-09-30 22:17:29 -07:00
Pete Koat
83f476ba8f
Merge branch '63d60d9'
2013-09-30 17:09:33 -07:00
Pete Koat
63d60d9826
Removed strong reference to UIImageView which was causing a crash in the nested block.
2013-09-30 17:02:32 -07:00
Olivier Poitrey
9820cafe9b
Merge pull request #498 from donholly/master
...
Added and exposed some methods that allow to check if an image exists on...
2013-09-20 11:03:18 -07:00
Olivier Poitrey
340db263fa
Remove WebP support from default target and add a dedicated target
...
Too many people have issue with WebP library dependancy.
2013-09-20 10:53:11 -07:00
Olivier Poitrey
03d28fee03
Only use the runloop with timeout on iOS 5 ( fix #497 )
2013-09-20 10:46:35 -07:00
Olivier Poitrey
0076bb9a55
Share schema so it can be used by Xcode bots
2013-09-20 10:45:35 -07:00
Don
8a2ae7e547
Fixed styling to match rs/SDWebImage repo
2013-09-12 13:45:11 -07:00
Don
547345c7f5
Added and exposed some methods that allow to check if an image exists on disk without taking it off disk and decompressing it first. Makes for a nice performance boost when checking if many files exist in the disk cache already
2013-09-12 11:58:43 -07:00
Olivier Poitrey
2bded38216
Merge pull request #487 from Gabro/patch-1
...
Enforced presence of a completedBlock in downloadWithURL:options:progress:completed
2013-08-29 07:41:34 -07:00
Gabriele Petronella
5bbddae80d
Updated doc marking the completedBlock parameter of downloadWithURL:options:progress:completed as required
2013-08-29 13:03:33 +01:00
Gabriele Petronella
f37474d5c8
Enforced presence of a completedBlock in downloadWithURL:options:progress:completed:
...
This method bails out in case of a missing `completedBlock`. While this makes sense (downloading the image without a completion block and not doing anything with it is pointless), a client passing a empty block is not informed about the mistake.
`NSParameterAssert` validates the input and it informs the client about bad usage of the API.
2013-08-29 12:46:15 +01:00
Olivier Poitrey
22cd4e49c4
Fix xcode project settings
2013-08-27 16:23:59 -07:00
Olivier Poitrey
7e2763a500
Merge pull request #479 from longlongjump/master
...
Fix long running requests
2013-08-23 08:19:52 -07:00
Eugene
16e1a1fff6
Fix long running requests
2013-08-23 00:49:45 +03:00
Olivier Poitrey
76d2fc8d0e
Update project to comply with Xcode 5
2013-08-20 16:25:27 -07:00