Commit Graph

2330 Commits

Author SHA1 Message Date
zhongwuzw c547adc2a9 Retain operation when post download related notifications 2019-01-07 17:05:03 +08:00
zhongwuzw 8a743950e2 Prioritize SDWebImageDownloaderHighPriority if operation already exists 2019-01-07 16:24:41 +08:00
zhongwuzw 6becff0f06 Fix race condition for creation of download operation when isCancelled is YES but isFinished is NO
Fix race condition for creation of download operation when isCancelled is YES but isFinished is NO

update comment
2019-01-07 16:05:53 +08:00
DreamPiggy 6dd92d11ff Use the memory bytes size, instead of pixel size to calculate the memory cost function 2019-01-03 15:59:22 +08:00
DreamPiggy b866c6aa97 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into 5.x
# Conflicts:
#	CHANGELOG.md
#	SDWebImage.podspec
#	SDWebImage.xcodeproj/project.pbxproj
#	SDWebImage/FLAnimatedImage/FLAnimatedImageView+WebCache.m
#	SDWebImage/SDImageCache.m
#	SDWebImage/SDWebImageDownloaderOperation.m
#	SDWebImage/UIView+WebCache.m
#	Tests/SDWebImage Tests.xcodeproj/project.pbxproj
2019-01-03 14:54:37 +08:00
DreamPiggy 3b19e76c6f Update the code for UIAnimatedImage associated with FLAnimatedImage case...This can happen when enable `GIF coder` as well as using FLAnimatedImageView 2019-01-03 14:21:18 +08:00
DreamPiggy c381506932 Fix the current image cost (pixels) for FLAnimatedImage, with a more correct value for memory cost function 2019-01-03 14:15:27 +08:00
DreamPiggy c95be0994e Update the category's naming for memory cache cost, a little code enhancement to avoid NSNumber generation 2019-01-03 12:08:18 +08:00
DreamPiggy e6a4e74ed5 Revert the changes for unused public API, polish comments 2019-01-03 11:49:06 +08:00
DreamPiggy 1700f9726d
Merge pull request #2486 from zhongwuzw/fix-cache-cost-miscalculation-for-master
Fix memory cache image cost miscalculation for animated images. Introduce the customized cost function for advacend feature.
2019-01-03 11:41:41 +08:00
Wu Zhong 6026cade7b
Merge pull request #2570 from dreampiggy/fix-background-download-4.x
Fix background download 4.x
2018-12-28 16:00:15 +08:00
zhongwuzw 9725c8da72 Remove edge case check 2018-12-28 11:14:19 +08:00
zhongwuzw 181d367215 Fix background download operation
FIx background download

Add task check when operation will deallocated && tidy code
2018-12-28 11:14:13 +08:00
zhongwuzw c58642976f put FLAnimatedImage fix into another PR 2018-12-27 21:30:07 +08:00
DreamPiggy 38a9222401
Merge pull request #2500 from zhongwuzw/fix-background-download
Fix background download
2018-12-27 14:42:35 +08:00
zhongwuzw de74bdca80 Remove edge case check 2018-12-26 20:29:09 +08:00
zhongwuzw 9617a34408 Fix background download operation
FIx background download

Add task check when operation will deallocated && tidy code

Tidy code further

Tidy further
2018-12-26 10:25:39 +08:00
DreamPiggy e6f7cb72cc
Merge pull request #2535 from dreampiggy/refactory_cache_path
Refactory cache path about namespace && final cache directory
2018-12-17 22:28:03 +08:00
DreamPiggy 1d540d3cb7 Fix the typo in the 5.0 migration guide 2018-12-16 14:32:01 +08:00
DreamPiggy 87f5f8b42f
Merge pull request #2556 from zhongwuzw/fix_nsmaptable_crash
Fix crash when NSMapTable empty keys
2018-12-13 19:36:21 +08:00
DreamPiggy 95dba7307d Update the migration guide for cache path about 5.0.0-beta version 2018-12-10 13:28:06 +08:00
zhongwuzw 216ba9c7e1 Fix crash when NSMapTable empty keys 2018-12-10 10:41:17 +08:00
DreamPiggy 1fc1de5da9 Update the migration guide for cache path 2018-12-09 15:23:26 +08:00
DreamPiggy b68730bedf Use the more intuitive and suitable cache path for SDImageCache. Defaults now to `~Library/Caches/com.hackemist.SDImageCache/default/`, namespace controls the sub-directory name.
Remove the namespacePrefix property because now it's not follows what it says
2018-12-09 15:23:26 +08:00
zhongwuzw cff0f33430 Add update image memory cost method 2018-12-09 11:56:51 +08:00
zhongwuzw 45427b1eed Merge branch 'remote-master' into fix-cache-cost-miscalculation-for-master 2018-12-09 10:45:38 +08:00
Chester Liu 9c527f0ebe
Merge pull request #2549 from zhongwuzw/add_define_module
Let SD can be imported using static library by CocoaPods
2018-12-09 09:06:56 +08:00
Wu Zhong b15abdd792
Merge pull request #2555 from dreampiggy/bugfix_macOS_xcconfig_bitcode
Fix that macOS does not support bitcode, current xcconfig cause build issue on Legacy Build System
2018-12-08 16:12:24 +08:00
DreamPiggy b0c84e8aec Fix that macOS does not support bitcode, this cause build issue on Legacy Build System 2018-12-08 12:57:11 +08:00
DreamPiggy 2cebcb7419 updated CHANGELOG 2018-12-05 18:36:45 +08:00
DreamPiggy 32d096a478
Merge pull request #2548 from SDWebImage/revert-2531-fix_reuse_wrong_image
Revert "Add image url check when set image"
2018-12-05 18:25:15 +08:00
zhongwuzw 72a34cf2cf Let SD can be imported using static library by CocoaPods 2018-12-03 10:58:24 +08:00
DreamPiggy 1b1cf603ed
Revert "Add image url check when set image" 2018-12-01 14:56:31 +08:00
Wu Zhong 2bdc51e65c
Merge pull request #2543 from langyanduan/master
fix: FLAnimatedImage custom property
2018-11-29 13:07:57 +08:00
langyanduan f47d60a802 fix: FLAnimatedImage custom property 2018-11-29 11:10:51 +08:00
DreamPiggy f663cab2c9 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into 5.x
# Conflicts:
#	CHANGELOG.md
#	README.md
#	SDWebImage.podspec
#	SDWebImage/FLAnimatedImage/FLAnimatedImageView+WebCache.m
#	SDWebImage/SDImageCache.m
#	SDWebImage/SDWebImageCompat.m
#	SDWebImage/SDWebImageDownloaderOperation.m
#	SDWebImage/SDWebImageManager.m
#	SDWebImage/UIView+WebCache.h
#	SDWebImage/UIView+WebCache.m
#	Tests/Tests/SDImageCacheTests.m
#	WebImage/Info.plist
2018-11-17 11:54:18 +08:00
Bogdan Poplauschi 4fd0e83521
Merge pull request #2531 from zhongwuzw/fix_reuse_wrong_image
Add image url check when set image
2018-11-16 10:28:40 -06:00
Bogdan Poplauschi e7c29639cb
Merge pull request #2532 from zhongwuzw/fix_comments
Fix comments in code
2018-11-15 20:18:26 -06:00
zhongwuzw 9dacf99738 update 2018-11-15 21:32:05 +08:00
zhongwuzw 8c7764e122 Fix comments in code 2018-11-15 21:13:27 +08:00
zhongwuzw c95c35d6db Add image url check when set image 2018-11-15 13:55:32 +08:00
Bogdan Poplauschi 944c57eaa9
Merge pull request #2530 from zhongwuzw/fix_flanimatedImage_step_2
Fix FLAnimatedImageView reuse wrong image && remove GCD strong retained
2018-11-14 09:40:07 -06:00
Bogdan Poplauschi 226f92f344
Merge pull request #2529 from zhongwuzw/fix_cacheType
Fix wrong image cache type when disk and memory cache missed
2018-11-14 09:38:05 -06:00
zhongwuzw 7e7a332278 Fix FLAnimatedImageView reuse wrong image && remove GCD strong retained 2018-11-14 21:03:29 +08:00
zhongwuzw 5611863f6a Fix wrong image cache type when disk and memory cache missed 2018-11-14 16:18:50 +08:00
DreamPiggy 772b79c824
Merge pull request #2494 from bpoplauschi/xcode_10
Xcode 10 + using xcconfig for project settings
2018-11-14 11:58:22 +08:00
Bogdan Poplauschi d89b735708 Fixed some warnings in the tests 2018-11-11 21:50:44 -06:00
Bogdan Poplauschi 205ce2af9a
Merge pull request #2524 from dreampiggy/fix_graphics_helper_bug
Fix the `SDGraphicsBeginImageContext` method recursive call issue
2018-11-11 21:35:54 -06:00
Bogdan Poplauschi f7a37ce72c iPhone 8 sim doesn't exist on Xcode10 (when targetting watch simulator). Use iPhone XS 2018-11-11 21:29:13 -06:00
Bogdan Poplauschi 887eeb4bc3 Fixes (use xcode10 image, no need for inputFileListPaths or outputFileListPaths) 2018-11-11 21:10:50 -06:00