Commit Graph

2477 Commits

Author SHA1 Message Date
DreamPiggy 691873117a Fix the logic to check loaders. Find the correct loader first and then check if optional protocol method is implemented 2019-04-02 16:32:15 +08:00
Kinarobin 48c1b0586e
Merge pull request #2666 from zhongwuzw/revert_domain_filter
Revert "Filter the error domain with NSURLErrorDomain before checking the URL Error Codes
2019-04-02 16:26:10 +08:00
DreamPiggy fa426f9b05 Update to use the delegate mode, let the actual image loader to decide whether to mark failed or not. 2019-04-02 15:00:07 +08:00
DreamPiggy 8275274154 Fix the blacking error domain should filter specify SDWebImageErrorDomain codes which is indeed un-recoverable 2019-04-02 12:09:27 +08:00
DreamPiggy b0f1006e3f
Merge pull request #2667 from zhongwuzw/guarantee_thread_safe
Guarantee thread-safe for SDImageCachesManager SDImageCodersManager SDImageLoadersManager
2019-04-01 17:44:22 +08:00
zhongwuzw 60255f5bd2 Thread-safe for CodersManager and LoadersManager 2019-04-01 17:19:11 +08:00
zhongwuzw aa890c5d9a Guarantee caches of CachesManager thread-safe 2019-04-01 16:00:13 +08:00
zhongwuzw 70d760af54 Revert "Filter the error domain with NSURLErrorDomain before checking the URL Error Codes"
This reverts commit 40abbd648d.
2019-04-01 11:03:04 +08:00
Wu Zhong 1faab6c863
Merge pull request #2661 from dreampiggy/fix_notification_name_duplicated_declare
Fix that `SDWebImageDownloadStartNotification` declare twice in header files
2019-04-01 10:39:53 +08:00
DreamPiggy 9d4b53118e Move the declare and the define into the downloader, make the import success. Update to NSNotificationName 2019-03-31 23:07:20 +08:00
DreamPiggy 9f262fc8cf Fix that `SDWebImageDownloadStartNotification` declare twice in header files. One is in downloader, another is in download operation 2019-03-31 21:26:55 +08:00
DreamPiggy 78071effe6 Update the changelog and readme to point to the master branch instead of 5.x Ready for merge back 2019-03-31 20:14:27 +08:00
DreamPiggy 2e7338894e Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into 5.x
# Conflicts:
#	SDWebImage/SDWebImageManager.m
2019-03-31 19:41:17 +08:00
DreamPiggy 456b6eadc6
Merge pull request #2648 from dreampiggy/bugfix_filter_error_domain
Filter the error domain with NSURLErrorDomain before checking the URL Error Codes
2019-03-31 19:29:40 +08:00
DreamPiggy cc13b18c21
Merge pull request #2660 from dreampiggy/bugfix_caches_manager_lock
Fix the thread safe issue of caches manager and specify the default caches array value.
2019-03-31 18:34:44 +08:00
DreamPiggy 75d3adedfa Update the coders manager initializer, without the useless mutable copy
Update the comments
2019-03-31 18:09:17 +08:00
DreamPiggy 36e89af004 Update the final 5.0.0 API diff and 5.0 migration guideline 2019-03-31 17:06:29 +08:00
DreamPiggy c913f2efc0 Merge branch 'master' of https://github.com/SDWebImage/SDWebImage into 5.x
# Conflicts:
#	SDWebImage/SDWebImageDownloader.m
2019-03-31 16:34:23 +08:00
DreamPiggy 47ad8d58d4
Merge pull request #2659 from dreampiggy/bugfix_macOS_animatedImageView
Bugfix macOS related small improvement for SDAnimatedImageView
2019-03-31 15:57:40 +08:00
DreamPiggy f060310ffe Remove the previous using atomic property, use lock instead. 2019-03-31 15:53:33 +08:00
DreamPiggy f9e80d18eb Fix the current caches manager, does not apply the SDImageCache.sharedImageCache. Fix the thread safe issue of caches manager.
Update the test cases and documents about this behavior.
2019-03-31 15:36:04 +08:00
DreamPiggy 505a89c029 Simplify the code of `animationRepeatCount`, since there are no override logic 2019-03-31 13:46:26 +08:00
DreamPiggy 3c28785d76 Fix the animated image view refresh rate issue when connecting a external monitor with different refresh rate 2019-03-30 20:01:17 +08:00
DreamPiggy 8237712d36 Update the macOS-specify comment and explain the reason of the `imageViewLayer` method. Update macOS 10.14 behavior. 2019-03-30 20:01:17 +08:00
DreamPiggy b0862c2d33
Merge pull request #2658 from dreampiggy/bugfix_animatedimage_unused_hack_intrinsicContentSize
Remove the unused hack of intrinsicContentSize for SDAnimatedImageView
2019-03-30 19:30:00 +08:00
DreamPiggy cf7a5a626b Remove the unused intrinsicContentSize for SDAnimatedImageView. This is original from FL and it's proved to be a of FL itself, but not what UIKit/AppKit behavior. 2019-03-30 15:47:41 +08:00
DreamPiggy 4235e3e302
Merge pull request #2657 from Gondnat/crashOnViewDelloc
Fix a crash, when SDAnimatedImageView dealloc, displayLinkContext in the async block will be a bad pointer
2019-03-29 17:52:51 +08:00
Gondnat d85f94da96 Fix a crash, when SDAnimatedImageView dealloc, displayLinkContext in block will be a bad pointer 2019-03-29 14:16:36 +08:00
DreamPiggy d9c8ba6da2
Merge pull request #2652 from dreampiggy/bugfix_xcconfig_xcode_10_2
Fix the issue cause build failure for Xcode 10.2
2019-03-28 15:10:36 +08:00
DreamPiggy c292fcccc4 Remove the unused ENABLE_BITCODE xcconfig, which cause issue for watchOS platform. Even without this xcconfig, all 4 platforms build product have the correct bitcode support 2019-03-27 22:07:42 +08:00
Kinarobin a00565181a
Merge pull request #2650 from dreampiggy/refactory_image_loader_protocol_naming
Rename the SDImageLoaderProtocol method naming to avoid the Selector conflict with SDWebImageManager and cause misunderstanding usage
2019-03-27 19:52:01 +08:00
DreamPiggy 110b49633f Fix the warning of deprecated project localization after upgrading Xcode 10.2 2019-03-26 18:03:14 +08:00
DreamPiggy bdd4667f4c
Merge pull request #2651 from Insofan/5.x
Clean some code to weakify && strongify macros which is depened on  pr #2647
2019-03-26 17:38:02 +08:00
DreamPiggy b09da860b9 Fix the issue cause build failure for Xcode 10.2.
Fix the wrong relative path of SDWebImage.xcodeproj
Fix the wrong xcconfig using ENABLE_BITCODE on debug configuration
2019-03-26 17:36:35 +08:00
Insomnia 0ad3dd4e5c Replace the weak-strong dance code with weakify && strongify depend on #2647 retry for travis failed 2019-03-26 01:11:01 +08:00
DreamPiggy 9fe1eee005 Rename the SDImageLoaderProtocol method naming to avoid the Selector conflict with SDWebImageManager and cause misunderstanding usage 2019-03-25 18:44:41 +08:00
DreamPiggy 6621f6a37d
Merge pull request #2647 from dreampiggy/project_weak_strong_macros
Introduce the internal macros and replace the weak-strong dance code with weakify && strongify
2019-03-25 18:28:01 +08:00
DreamPiggy 9453c2e095 Remove the deprecated GCC_VERSION build settings for Demo project 2019-03-23 10:10:04 +08:00
DreamPiggy d36d5e7936 Revert "Move the dispatch_main_async_safe into internal macros, since it's used in implementation files but not headers"
This reverts commit e702214f82.
2019-03-22 10:57:23 +08:00
DreamPiggy 57ad6853ed Update SDWebImagePrefetcher weak-strong dance code into weakify && strongify 2019-03-21 19:46:25 +08:00
DreamPiggy 08c6e22906 Rename metamacro.h filename with SDmetamacro.h 2019-03-21 19:38:09 +08:00
DreamPiggy c6fe902a30 Fix the SDWebImage Test project using the framework xcconfig, should ignore the prefix header 2019-03-21 19:38:09 +08:00
DreamPiggy a065fa2379 Rename pch file with Prefix.pch, make it easy to distinguish from the umbrella headers 2019-03-21 19:38:09 +08:00
DreamPiggy e702214f82 Move the dispatch_main_async_safe into internal macros, since it's used in implementation files but not headers
SDWebImageCompat.h should only contain the macros support used in header
2019-03-21 19:38:09 +08:00
DreamPiggy c6247d2d63 Using pch for the internal macros, to avoid each implementation files import this macro 2019-03-21 19:38:09 +08:00
DreamPiggy e31a44f6a1 Replace all the weak-strong dance code with @weakify and @strongify 2019-03-21 19:38:09 +08:00
DreamPiggy 367f4454b6 Add the private @weakify @strongify @onExit macros to simplify the code in implementation files 2019-03-21 19:38:09 +08:00
DreamPiggy 40abbd648d Filter the error domain with NSURLErrorDomain before checking the URL Error Codes 2019-03-21 11:32:36 +08:00
DreamPiggy 9e36d2c54c
Merge pull request #2633 from iliaskarim/IK/SDWebImageDownloader/ConvenienceMethod
Define SDWebImageDownloader convenience method
2019-03-21 11:06:04 +08:00
Kinarobin 07204d5a60
Merge pull request #2645 from zhongwuzw/fix_prefetch_hung_up
Fix prefetch hung up
2019-03-21 10:42:23 +08:00