Commit Graph

626 Commits

Author SHA1 Message Date
Klaas Pieter Annema 825207d1d0 Add imageURL property to remaining categories 2014-06-12 13:31:40 -04:00
Klaas Pieter Annema 77be243598 Add documentation to imageURL property 2014-06-12 13:30:48 -04:00
Klaas Pieter Annema 074ce1f4cf Keep a reference to the image URL 2014-06-12 13:30:48 -04:00
Olivier Poitrey f5bd783b5e Merge pull request #701 from billburgess/delayplaceholder
Delay the loading of the placeholder image until after load
2014-06-12 06:38:34 -07:00
Bogdan Poplauschi 3284e157ff Documented SDWebImageDownloaderOperation initWithRequest:options:progress:completed:cancelled: method. Fixes #526 2014-06-12 14:58:32 +03:00
Bogdan Poplauschi fe48ee54f3 Added SDWebImageCompat.m to SDWebImage+MKAnnotation target 2014-06-11 12:46:20 +03:00
Bogdan Poplauschi 5b59677437 Fixed #384 (documentation wrognly stated a return type was NSOperation) 2014-06-11 11:52:06 +03:00
Bogdan Poplauschi 12ee2d114b Updated README.md to fix #476 2014-06-11 11:44:45 +03:00
robertmryan f63a45add6 Adjusted completion logic in prefetcher, as the old implementation would finish prematurely if any requests were skipped.
Also adjusted documentation in headers to make it clear that the `finishedCount` includes both successful and unsuccessful requests.
2014-06-11 02:36:47 -04:00
robertmryan a46f6149e5 Resolve race condition.
While exceedingly unlikely, the old construct introduced potential race condition where it checked wself first, and assigned sself second. This now assigns sself first, and then checks that, which is the correct pattern, already used elsewhere in SDWebImage.
2014-06-11 02:14:40 -04:00
Bogdan Poplauschi 257da39e4d Merge pull request #732 from dchohfi/master
#725 adding completition block when removing image from cache
2014-06-10 13:41:43 +03:00
Bogdan Poplauschi caf3299c27 Merge pull request #744 from Pei116/master
fixed SDWebImageRefreshCached bug for large images
2014-06-10 13:38:28 +03:00
Bogdan Poplauschi 3b32f1dd9d Merge pull request #741 from martinblech/master
Synthesize `executing` and `finished` properties.
2014-06-08 19:00:31 +03:00
Edison Chang f43dd896fa fixed SDWebImageRefreshCached bug for large images 2014-06-04 12:36:11 +08:00
Olivier Poitrey 542d930f10 Merge pull request #742 from openresearch/master
Fix getter names. Fixes commit: 097b502eae
2014-06-03 14:26:08 -07:00
Philipp Schmid 5f239c07b8 Fix getter names. Fixes commit: 097b502eae
The getters of the properties “executing” and
“finished” both use custom getter names.

097b502eae implemented the wrong getter names
without the “is” prefix.
2014-06-03 22:42:15 +02:00
Martin Blech 241dafdd57 Synthesize `executing` and `finished` properties.
It wouldn't build on Xcode 6 otherwise.
2014-06-03 11:37:22 -03:00
Olivier Poitrey a83f440269 Merge pull request #737 from openresearch/master
Fix build on Xcode6
2014-06-02 15:04:53 -07:00
Philipp Schmid 097b502eae Fix build on Xcode6 2014-06-02 23:59:57 +02:00
Olivier Poitrey 4566b67f98 Merge pull request #735 from nickhingston/pullRequestBranch
If NSURLConnection response statusCode not valid (e.g. 404) , downloader...
2014-06-02 10:10:16 -07:00
Nick Hingston db614bc53e If NSURLConnection response statusCode not valid (e.g. 404) , downloader never stops its runloop and hangs the operation queue 2014-06-02 12:42:24 +01:00
Olivier Poitrey 5b3c54ba16 Merge pull request #734 from soundcloud/master
add a suspension method to image downloaders
2014-06-02 02:23:59 -07:00
Richard Howell 2c5ee720ba add a suspension method to image downloaders 2014-06-02 11:12:26 +02:00
Diego Chohfi 2ca5eab0e5 #725 adding completition block when removing image from cache, added an extra method so we don't break compatibility with older versions 2014-05-29 11:05:43 -03:00
Bogdan Poplauschi 7edeef9f1a Updated README.md with CocoaPods install 2014-05-28 09:46:40 +03:00
Olivier Poitrey fca411224b Merge pull request #728 from kejinlu/master
The ioQueue is "SERIAL" ,so "dispatch_barrier_async" is not needed.
2014-05-24 10:38:16 -07:00
卢克 dab65ae8f5 The ioQueue is "SERIAL" ,so "dispatch_barrier_async" is not needed. 2014-05-24 21:08:39 +08:00
Olivier Poitrey 7764e47a36 Merge pull request #727 from kejinlu/master
It's generally a bad idea to remove items from a container while iterating through it.
2014-05-23 15:00:20 -07:00
卢克 b1203d4a9e It's generally a bad idea to remove items from a container while iterating through it. And fix the thread safe issue. 2014-05-23 17:44:59 +08:00
Whirlwind acac18d6a2 fix UIImageView+HighlightedWebCache call error method 2014-05-22 22:55:21 +08:00
Olivier Poitrey 1c5060369e Merge pull request #721 from rivera-ernesto/improve_logging
Improve logging and fix arm64 warnings when printing integers with %d
2014-05-21 22:44:47 -07:00
Olivier Poitrey 36d5069b66 Merge pull request #720 from rivera-ernesto/update_projects
Update projects to Xcode recommended settings
2014-05-21 07:47:16 -07:00
利辺羅エルネスト 29302f49b3 Improve logging and fix arm64 warnings when printing integers with %d 2014-05-21 17:15:01 +09:00
利辺羅エルネスト 6c79daad00 Update projects to recommended settings 2014-05-21 17:10:25 +09:00
Olivier Poitrey 6f02d77add Merge pull request #646 from Whirlwind/master
add category for imageView's highlighted state
2014-05-20 23:39:25 -07:00
derpoliuk 78a50d3929 Adds -[SDWebImageManager saveImageToCache:forURL:] method 2014-05-13 11:11:36 +03:00
Bill Burgess 9a45faac3f Wrapped placeholder check in parens to work with bitwise 2014-04-29 10:27:54 -05:00
Bill Burgess 7ca81d0e36 Updated bitwise operator to correctly find option if more than 1 are included 2014-04-29 10:13:28 -05:00
Bill Burgess f7ee9d3375 Moved the delay placeholder flag to SDWebImageOptions 2014-04-28 12:30:27 -05:00
Bill Burgess 12715da31b Overload -setImageWithURL to delay setting of placeholder image until after loading 2014-04-28 10:07:43 -05:00
Olivier Poitrey 8fe72023dc Merge pull request #700 from herrernst/master
Save image in cache before calling completion block
2014-04-28 12:31:04 +02:00
herrernst 83843a493a Save image in cache before calling completion block 2014-04-26 12:43:25 +02:00
Olivier Poitrey c9a24e294a Merge pull request #698 from salling/master
Fixing race in SDWebImageDownloaderOperation leading to erroneous timeout.
2014-04-22 18:35:30 +02:00
Jonas Salling bdef7651f0 Update SDWebImageDownloaderOperation.m
Fixing race condition that causes cancellation of one download operation to stop a run loop that is now used for another download operation. Race is introduced through -performSelector:onThread:withObject:waitUntilDone:
2014-04-22 14:52:20 +02:00
Olivier Poitrey 88e6ca3e49 Merge pull request #694 from shifu/master
Port Max's crash fix to my 3.6 fork
2014-04-16 20:22:13 -07:00
Chang Luo 1f202ed7a3 Port Max's crash fix to my 3.6 fork 2014-04-16 16:06:22 -07:00
Ruslan Ahapkin c285074321 Create NSOperation when start operation.
Method getDiskCount returns NSUInteger.
2014-04-03 23:16:48 +04:00
Olivier Poitrey db86161132 Merge pull request #685 from jeffleeismyhero/patch-1
Updates progress callback to use NSInteger
2014-04-03 07:52:00 -07:00
Jeffrey Lee 065db6db0c Updates progress callback to use NSInteger
Pull Request #606 resolves this issue in the code but not in the Documentation.
2014-04-03 09:37:08 -05:00
Bryn Bodayle ec5369db13 Fixed issue where cancelled operations aren't removed from runningOperations 2014-04-01 10:21:11 -05:00