b9d9456e21
Fixed documentation spelling.
2014-07-23 08:59:52 -04:00
959e8db914
Bumped podspec version
2014-07-23 08:17:14 +03:00
e95224bf5f
Temporary fix for #809 , until we can figure out the cause of the crash
2014-07-23 08:13:25 +03:00
f96302b427
Merge pull request #827 from BB9z/fix/pargma-mark
...
Missing mark.
2014-07-22 12:17:09 +03:00
f6d7d60b98
Missing mark.
2014-07-22 16:58:08 +08:00
222e6bca0d
Merge pull request #795 from xlchen/master
...
fix duplicate symbols when using with webp via pods
2014-07-21 15:32:45 +03:00
28109c4c70
Fixed SDWebImageCombinedOperation cancel crash ( #798 #809 )
2014-07-21 15:27:16 +03:00
7d93374067
Modified the cost calculuations to appropriately compute the 'scale' of an image
2014-07-20 18:10:02 -04:00
c8df858f75
Added test for the UIImage+MultiFormat crash
2014-07-18 16:56:32 +03:00
681a7c4222
Merge pull request #819 from n13/master
...
guarding against image source == NULL
2014-07-18 16:21:16 +03:00
9faee5356c
guarding against image source == NULL
2014-07-18 11:07:13 +07:00
b88a552fba
Updated all block params and properties, using defined blocks that have var names (for proper autocomplete). Created a SDWebImageNoParamsBlock to distinguish easier from other no params blocks. Fixes #810
2014-07-16 15:17:08 +03:00
cd4b925448
Update to #732 to fix misspell (completion instead of completition)
2014-07-14 18:29:45 +03:00
db252d3654
Updated podspec version to 3.7.0
2014-07-14 18:12:07 +03:00
f080e38fb8
Replace #699 Fixed race condition in SDWebImageManager if one operation is cancelled, the completion block must not be called, otherwise it might race with a newer completion for the same object
...
Conflicts:
SDWebImage/SDWebImageManager.m
2014-07-14 16:29:57 +03:00
6e4fbafa55
#625 In order to fix the deadlock, reviewed the `[SDImageCache diskImageExistsWithKey:]` method. Based on the Apple doc for NSFileManager, using the defaultManager without the dispatch on the ioQueue to avoid the deadlocks. This instance is thread safe. Also created an async variant of this method `[SDImageCache diskImageExistsWithKey:completion:]`
...
For consistency, added async methods in `SDWebImageManager` `cachedImageExistsForURL:completion:` and `diskImageExistsForURL:completion:`
2014-07-14 16:22:00 +03:00
0b47342b2f
No need for explicit ivar and getters, as long as we have the @synthesize in place
2014-07-14 13:01:05 +03:00
39db378082
Merge pull request #783 from bpoplauschi/race_condition
...
Replace #621Fixed race condition between operation cancelation and loading finish
2014-07-11 09:57:28 +03:00
894a1b1810
Merge pull request #794 from vjyanand/master
...
Update MKAnnotationView+WebCache.m
2014-07-10 10:57:51 +03:00
99590ed6ec
Update MKAnnotationView+WebCache.m
...
Replace deprecated method call
2014-07-06 06:40:06 -04:00
2e708d3518
Updated README.md with badges
2014-07-04 10:56:09 +03:00
30e034d60d
Fixed misspell
2014-06-30 00:07:32 +03:00
72a4e7b830
Replace #621Fixed race condition between operation cancelation and loading finish
2014-06-26 00:30:45 +03:00
30f672661c
Added option to use the cached image instead of the placeholder for UIImageView. Replaces #541 . Fixes #599
2014-06-26 00:27:56 +03:00
a6f11b3ad7
Fixed #775 , made sure all the category methods that are public have the sd_ prefix (deprecated the old ones)
...
-there were a few exceptions where I just renamed the methods since they were added in this method
2014-06-25 21:32:53 +03:00
23874cdca4
Update for #771 - instead of removing the old methods, deprecated them so we are backwards compatible.
2014-06-25 11:24:59 +03:00
6d01e80409
Added comments and coding style to previous pull request #771
2014-06-25 11:04:28 +03:00
9b18145e56
Merge pull request #771 from Whirlwind/new_cancel_logic
...
Refactor the cancel logic
2014-06-25 10:49:44 +03:00
3a7adbbacf
Merge pull request #780 from rokgregoric/master
...
Do not load placeholder image if SDWebImageDelayPlaceholder option specified.
2014-06-24 18:29:09 +03:00
8d668b4121
Do not load placeholder image if SDWebImageDelayPlaceholder option specified.
2014-06-24 12:49:34 +02:00
50c4d1d2eb
Implemented NTLM auth support. Replaced deprecated auth challenge methods from `NSURLConnectionDelegate`. Replaces #711 .
...
- added `username` and `password` properties on `SDWebImageDownloader`
- added `shouldUseCredentialStorage` and `credential` properties on `SDWebImageDownloaderOperation`
- `SDWebImageDownloaderOperation` conforms to `NSURLConnectionDataDelegate` (it used to implement the methods, but didn't stated the protocol in the declaration)
- removed deprecated methods: `- connection:canAuthenticateAgainstProtectionSpace:` and `- connection:didReceiveAuthenticationChallenge:` with `- connectionShouldUseCredentialStorage:` and `- connection:willSendRequestForAuthenticationChallenge:`
- updated demo project to download one image the requires HTTP auth
2014-06-23 21:57:33 +03:00
c7330db3a6
Merge branch 'unit_tests'
...
Unit testing setup + created workspace
- created a SDWebImage.xcworkspace
- includes the existing SDWebImage.xcodeproj (responsible of compiling the library)
- includes the existing SDWebImage Demo.xcodeproj
- includes the newly created SDWebImage Tests.xcodeproj (tests project). The test project uses the local CocoaPods repo to link to the library
Unit testing backbone:
- XCTest framework (the one from Apple)
- XCTestAsync - extension for XCTest that allows easily creating asynchronous tests. Relies on dispatch_after.
- Expecta - matcher Framework for Objective-C/Cocoa
Updated gitignore
2014-06-23 21:23:56 +03:00
e5faad0026
Reverted demo project referencing source files directly. Re-added SDWebImage project as subproject
2014-06-20 18:04:06 +03:00
e0b3de4357
Added error test
2014-06-20 17:51:40 +03:00
c1fae30d63
Added SDWebImage Tests project. It uses CocoaPods (Expecta + XCTestAsync). Added some demo tests
2014-06-20 17:21:01 +03:00
60b043755f
Created a SDWebImage workspace with the 2 existing projects, fixed the demo project so it directly references the source files. Shared a demo project scheme
2014-06-20 16:41:53 +03:00
7855f89185
Prepared gitignore for CocoaPods and workspaces
2014-06-20 16:40:43 +03:00
fe4b3a088a
Fixed warnings from demo project (started using the new methods, the ones with the sd_ prefix).
2014-06-20 10:07:12 +03:00
5615cf12de
Merge branch 'master' into new_cancel_logic
...
Conflicts:
SDWebImage/MKAnnotationView+WebCache.m
SDWebImage/UIButton+WebCache.m
SDWebImage/UIImageView+HighlightedWebCache.h
SDWebImage/UIImageView+HighlightedWebCache.m
SDWebImage/UIImageView+WebCache.m
2014-06-20 10:51:17 +08:00
af3e4f87e4
Returning error in setImage completedBlock if the url was nil. Added `dispatch_main_async_safe` macro. Fixes #505
2014-06-19 23:24:08 +03:00
eb91fdd3b8
Fixed issue #529 - if the `cacheKeyFilter` was set, this was ignored when computing the `scaledImageForKey`. For most of the developers that did not set `cacheKeyFilter`, the code will work exactly the same
2014-06-19 23:05:14 +03:00
a8a69ab9b6
Merge pull request #770 from bpoplauschi/completion_with_url
...
Pass imageURL in completedBlock
2014-06-19 12:38:12 -07:00
136daba9df
Added proper handling for SDWebImageDownloaderLowPriority (aka NSOperationQueuePriorityLow). Fixes #713 #745
2014-06-19 22:19:22 +03:00
e116aa5ce0
Updated some older code to match the coding style
2014-06-19 21:58:20 +03:00
ea663b9602
As discussed with @rs, prefixed all the new methods to sd_set*
2014-06-19 21:54:25 +03:00
4c18545dbc
Refactor the cancel logic
2014-06-19 22:46:37 +08:00
03a751430d
Pass image URL in completion blocks - step 6:
...
- deprecated block type `SDWebImageCompletedBlock `, replaced with `SDWebImageCompletedBlock ` that contains NSURL* param
2014-06-19 12:27:08 +03:00
81b5e72a9c
Pass image URL in completion blocks - step 5:
...
- deprecated all UIImageView(WebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type
- created WebCacheDeprecated category on UIImageView (to avoid collisions, we didn't name it Deprecated)
- replaced the usages of the deprecated items with the new ones
2014-06-19 12:26:12 +03:00
21b230f28f
Fixed misspell (downloand -> download)
2014-06-19 12:13:39 +03:00
76b552e21e
Pass image URL in completion blocks - step 4:
...
- deprecated all UIImageView(HighlightedWebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type
- created HighlightedWebCacheDeprecated category on UIImageView (to avoid collisions, we didn't name it Deprecated)
- replaced the usages of the deprecated items with the new ones
2014-06-19 12:12:58 +03:00
David Messing
Bogdan Poplauschi
Bogdan Poplauschi
BB9z
mishagray
Nikolaus Heger
Vjy Anand
Rok Gregorič
Whirlwind
Olivier Poitrey