c7c1cde776
Merge pull request #3265 from RbBtSn0w/3.x
...
Fix SDWebImageCombinedOperation was leak.
2021-09-30 17:30:18 +08:00
e7210f104d
Fix SDWebImageCombinedOperation was leak.
...
When the task is executed in a concurrent queue, when the user scrolls up and down in the List, the function call "sd_setImageWithURL:placeholderImage:options:progress:completed:" will be triggered to "SDWebImageCombinedOperation cancel",
and the real task will be Cancel was called, which caused the task to be executed in multi-threaded execution until the "operation.isCancelled" in "SDImageCache queryDiskCacheForKey:done:" was returned.
Through the principle of opening and closing, when we add, we guarantee that there must be a place to be removed.
Since the block supports the ability of external coverage, the approach here is the same as
operation.cancelBlock = ^{
[subOperation cancel];
This code does not conflict
There is a bug that SDWebImageCombinedOperation is not released.
2021-08-20 19:43:04 +08:00
2eca5c7f04
Merge pull request #3054 from dvshelley/3.xTargetDeployment9
...
change deployment target to iOS 9 to fix Archiving with Xcode 12
2020-08-04 19:09:34 +08:00
59f630b0db
change deployment target to iOS 9 to fix Archiving with Xcode 12
2020-07-17 16:18:26 -06:00
59a28c27b2
Merge pull request #2893 from dvshelley/3.x
...
fix Xcode 11 warnings
2019-11-28 12:07:41 +08:00
54f25b20b6
fix Xcode 11 warnings
2019-11-19 16:48:34 -07:00
8869372622
Bumped version to 3.8.3
2019-06-05 12:57:57 +08:00
cc09c9fbfe
Merge pull request #2744 from dvshelley/3.x-Xcode11
...
fix compatability for Xcode 11
2019-06-05 12:48:31 +08:00
b6cfd802f9
fix compatability for Xcode 11
2019-06-04 09:26:31 -06:00
42a5e6f6ec
Bumped version to 3.8.2
2016-09-05 20:11:18 +03:00
e7bd5ab0fa
Improvement for #1608 and #1623 should solve the issue for most of the cases. Apparently there is a race condition on NSURLCache and we avoid making those checks unless necesarry (basically we will query the NSURLCache only when `SDWebImageRefreshCached` is used and the image cannot be cached by the system when it's too big or behind authentication)
2016-09-05 19:53:39 +03:00
dea7b4594d
Actually we only want the RefreshCached flag for the 1st image (the HTTP Auth one)
2016-09-02 20:17:53 +03:00
20760d71e5
Updated code for #1608 #1623 - set a name for the download queue, avoid using the `_request` ivar and made sure we strip request of mutability
2016-09-01 15:05:30 +03:00
033899d0ac
Example updated: all images use the SDWebImageRefreshCached option
2016-09-01 14:26:54 +03:00
c012fc9bb2
Updated the changelog
2016-06-07 12:00:00 +03:00
67329ac512
Bumped the version
2016-06-07 11:57:03 +03:00
de149aedaa
Reverted all the changes for "Removed the URL query params from the filename (key)" fb0cdb6d 1bf62d4 #1584 - fixes #1433 #1553 #1583 #1585
...
This is a deal breaker for people. The solution for those issues (i.e. very long urls) is to set the SDWebImageManager cacheKeyFilter block and do their own calculations there.
2016-06-07 11:56:31 +03:00
fc0de57066
Readded `shouldUseCredentialStorage` to preserve backwards compatibility
2016-06-06 21:24:11 +03:00
473054879c
Updated the changelog
2016-06-06 21:08:17 +03:00
5d42a2ac5e
Merge pull request #1586 from oanapopescu/nsurlsession
...
Updated image downloader with a single session that manages all tasks
2016-06-06 21:00:34 +03:00
1e412927cc
Keeping both owned and unowned sessions around as part of the operation.
...
We need different ownership for both because we need to invalidate the owned session upon completion.
The unowned session is wet to avoid cyclical references.
2016-06-06 20:09:43 +03:00
eab4279140
Updated image downloader with a single session that manages all tasks
...
- the URL session is created and maintained y the image downloader
- the session will be injected to each operation and it will use it to create the data task
- when delegate callbacks are called, the downloader will call the same delegate methods on the appropriate operation
- if no session is injected upon creating a operation, it will create its own session for backwards compatibility.
2016-06-06 19:12:56 +03:00
1bf62d475a
Fixed #1583 crash in `SDWebImageManager cacheKeyForURL:` when url is nil - replaced #1585
2016-06-06 07:32:34 +03:00
d8dc6a25aa
Merge pull request #1584 from minsOne/master
...
fixed crash on ios7 user device
2016-06-06 07:25:00 +03:00
335a437b2e
fixed crash on ios7 user device
...
fixed that string property of NSURLComponents can`t use on iOS7
2016-06-06 04:42:02 +09:00
cb7a3db23c
Updated the changelog
2016-06-02 19:19:42 +03:00
6545a3aba1
Bumped the deployment target to iOS 7 (due to NSURLSession) and also incremented the library version to 3.8.0
2016-06-02 19:10:31 +03:00
9137b65d3b
Merge pull request #1578 from oanapopescu/nsurlsession
...
Replace deprecated NSURLConnection with NSURLSession
2016-06-02 18:59:05 +03:00
09a9e74eae
Removed dealloc method and added comment regarding sending nil for delegateQueue
2016-06-02 18:23:49 +03:00
5580c78282
Replace deprecated NSURLConnection with NSURLSession. See #1291 #1318 #823 #1566
...
- one session per operation to preserve the ordering and priority functionalities
- removed all the runloop code that was only used to keep the operation running. I am relying on non-setting the isFinished property to keep the operation running
- todo: check deallocation, test background tasks
2016-06-02 09:02:03 +03:00
af7b587936
Fixed #1573 - Update to cc510a6 - Cached file name with path extension UIWebView issue - for iOS 7 and above, remove the query from the url (prior to iOS 7 the behavior remains the same).
2016-05-31 14:51:33 +03:00
86fc47bf7b
Replaces #1398 Allow to customise cache and image downloader instances used with SDWebImageManager - added a new initializer (`initWithCache:downloader:`)
2016-05-30 07:31:01 +03:00
e6e5c5156b
Fixed #1415 documentation was not updated when `removeImageForKey:` became async
2016-05-29 22:32:15 +03:00
cc510a6a4e
Fixed #1553 Cached file name with path extension UIWebView issue - for iOS 7 and above, remove the query from the url (prior to iOS 7 the behavior remains the same).
2016-05-29 16:25:31 +03:00
0dc2c41112
Trying to get around this last build error "The certificate for this server is invalid. You might be connecting to a server that is pretending to be “www.google.gr†which could put your confidential information at risk." by using a different image
2016-05-29 12:49:06 +03:00
f8a7b6bac7
The pod setup output is huge with CocoaPods 1.0.0 (10.000+ lines), causes Travis to "This log is too long to be displayed. Please reduce the verbosity of your build or download the raw log."
2016-05-29 12:48:26 +03:00
8e300c92a4
Need to clean the SDWebImage scheme to allow the tests to rebuild it using their required platform.
2016-05-29 00:50:24 +03:00
44eac986bb
Another attempt at the build
2016-05-29 00:44:02 +03:00
afaf306222
This should fix the build (the tests project)
2016-05-29 00:00:33 +03:00
5ac4e308c7
Fixed the Tests/Podfile, the Target ios was not to be found, so took advantage of this change to simplify it
2016-05-28 23:00:16 +03:00
f1a471e93f
Fixed #1444 and the master build thanks to 5034c334be
2016-05-28 22:50:53 +03:00
11840d1313
Attempt to fix the latest build (failed because of Invalid `Podfile` file: [!] The specification of `link_with` in the Podfile is now unsupported, please use target blocks instead.)
2016-05-28 22:07:18 +03:00
1f165b48ee
Added CONTRIBUTING, ISSUE and PULL_REQUEST TEMPLATE
2016-05-28 21:46:40 +03:00
edb4bc3554
Updated the changelog
2016-05-08 19:49:06 +03:00
990f85bce2
Bumped version to 3.7.6
2016-05-08 19:32:10 +03:00
b40124c95d
Fixed #1449 : Version 3.7.5 breaks semantic versioning (removes public API). Re-added `sd_setImageWithPreviousCachedImageWithURL:andPlaceholderImage:options:progress:completed:` and deprecated it. Will remove it in 4.0.0
2016-05-08 19:00:39 +03:00
371533549c
Merge pull request #1453 from Mutix/master
...
Added API to save image NSData to disk cache.
2016-05-08 18:53:26 +03:00
d4d11ef0b0
Merge pull request #1461 from jawwad/patch-1
...
Improve documentation for SDWebImageHighPriority
2016-05-08 18:43:52 +03:00
d6d9a5c233
Merge pull request #1504 from siburb/master
...
Added "cancelAllDownloads" method to SDWebImageDownloader.
2016-05-08 18:41:36 +03:00
1fba8d99f3
Merge pull request #1549 from iOSPandaLee/master
...
Repair memory release in the iPad environment
2016-05-08 18:35:47 +03:00
DreamPiggy
snow.wu
Kinarobin
Daniel Shelley
Bogdan Poplauschi
Bogdan Poplauschi
Oana Popescu
Ahn Jung Min
Bogdan Poplauschi